fix: remove trait bounds from where clause in IntoWasmAbi expansion - #72
fix: remove trait bounds from where clause in IntoWasmAbi expansion#72dsgallups wants to merge 3 commits into
IntoWasmAbi expansion#72Conversation
wip: correcting output fix: test
|
Sorry this sat for so long — thanks for tracking the bug down. The diagnosis is exactly right: Two things came up while getting it ready to land: 1. #[derive(Tsify)] #[tsify(into_wasm_abi, from_wasm_abi)]
pub struct GenericLifetime<'a: 'b, 'b> { x: &'a str, y: &'b str }
#[derive(Tsify)] #[tsify(into_wasm_abi, from_wasm_abi)]
pub struct GenericConst<const N: usize> { x: u32 }
let predicate: syn::WherePredicate = {
let (_, ty_generics, _) = generics.split_for_impl();
parse_quote!(#ident #ty_generics: #serde_path::Serialize)
};
generics.make_where_clause().predicates.push(predicate);2. The expected output needs regenerating. Since this branch doesn't have "Allow edits from maintainers" enabled, I can't push these here, so I've opened #89 with your commits rebased onto |
This PR fixes an issue with trait implementation where you have
This is because the implementation of traits would have an invalidate generic constraint in the where clause:
This has been fixed: