fix(ui): render "then" separator between hotkey tokens and shortcuts in Tooltip - #5516
Open
nandanadileep wants to merge 1 commit into
Open
fix(ui): render "then" separator between hotkey tokens and shortcuts in Tooltip#5516nandanadileep wants to merge 1 commit into
nandanadileep wants to merge 1 commit into
Conversation
When a Tooltip renders both a hotkey token list and a custom shortcut list, the last token never emitted the "then" separator because the condition only checked tokens().length. Include shortcuts().length in the guard so multi-step sequences render correctly across the boundary.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe tooltip now renders the “then” separator after the final registered hotkey when raw shortcuts follow it. 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5338
Summary
In
apps/web/src/components/ui/components/Tooltip.tsx, when a Tooltip renders both ahotkeytoken list and a customshortcutlist, the"then"separator was missing between the last hotkey token and the first shortcut.The separator guard only checked
ndx() < tokens().length - 1, which isfalseon the last token, so nothing was rendered before the first shortcut item.Fix
The
"then"separator now also renders when there are remaining shortcut items:Multi-step sequences like
cmd+k then <shortcut>now render"then"correctly across the hotkey/shortcut boundary.Verification
bun run check(type-check + biome) passes inapps/web.