Skip to content

chore(nix): consolidate development shells - #5512

Open
seanaye wants to merge 1 commit into
mainfrom
seanaye/chore/improve-dev-shell
Open

chore(nix): consolidate development shells#5512
seanaye wants to merge 1 commit into
mainfrom
seanaye/chore/improve-dev-shell

Conversation

@seanaye

@seanaye seanaye commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

This PR removes the js-app dev shell an introduces tauri specific dev shells. The idea being typically people generally are doing full stack development so having a FE + BE dev shell doesn't make much sense especially when many of the dependencies overlap.

We just have tauri specific dev shells to keep large heavy dependencies outside of the devshell (like android studio)

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 92619d93-696d-47c6-99d8-eb039a7e30de

📥 Commits

Reviewing files that changed from the base of the PR and between 8480d35 and b8ef21d.

📒 Files selected for processing (7)
  • README.md
  • apps/web/README.md
  • apps/web/docs/graphql-cache-optimistic-enqueue-claim-plan.md
  • crates/client/README.md
  • nix/cloud-storage.nix
  • nix/js-app.nix
  • nix/tauri-dev-shells.nix
💤 Files with no reviewable changes (1)
  • nix/js-app.nix

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Added dedicated development environments for Linux desktop and Android app development.
    • Added tooling for Tauri, Android, AWS infrastructure, browser testing, and Playwright-based workflows.
    • Added platform-specific setup guidance, including required system libraries and external IDE support.
  • Documentation

    • Updated development and testing instructions to use the appropriate platform-specific environments.
    • Removed obsolete JavaScript app shell guidance.

Walkthrough

Added tauri-linux and tauri-android Nix development shells with platform-specific Rust, Android, Linux runtime, and environment configuration. Extended shared development tools with Tauri, Pulumi, Playwright, and related packages. Removed the previous JavaScript development shell. Updated project documentation and Tauri verification commands to use the new shells.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title uses conventional commits format and is 42 characters long, which is under the 72-character limit.
Description check ✅ Passed The description explains the removal of the js-app shell and the introduction of Tauri-specific development shells.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant