Skip to content

feat(launcher): create menu pages - #5411

Open
ehayes2000 wants to merge 6 commits into
claude/macro-task-review-nbj5xnfrom
create-menu-pages
Open

feat(launcher): create menu pages#5411
ehayes2000 wants to merge 6 commits into
claude/macro-task-review-nbj5xnfrom
create-menu-pages

Conversation

@ehayes2000

Copy link
Copy Markdown
Contributor

No description provided.

claude and others added 6 commits July 30, 2026 22:46
… menu, and creation flow

Skills are markdown documents (new document sub type 'skill', mirroring the
task/snippet subtypes) containing instructions that AI reads and follows when
a skill is referenced in an AI input.

Backend:
- Add 'skill' to document_sub_type enum + macrodb migration, and thread it
  through every subtype match site (models, soup, graphql, notifications,
  properties entity-type mapping, search indexing).
- New POST /documents/create_skill endpoint mirroring create_snippet.
- New skills crate (hexagonal): SkillService domain service, SkillSearcher
  port, search-service outbound adapter (access-aware name search filtered to
  the skill sub type), and a SearchSkills AI tool wired into ai_tools
  (subagent + MCP toolsets) via SkillToolContext.

Frontend:
- '/' in AI markdown areas opens a skills typeahead (skillsPlugin +
  SkillsMenu, reusing the mentions menu components); selecting a skill
  inserts an m-document-mention node with blockName 'skill'.
- Skill creation via the create menu with hotkey C+L (Launcher block,
  create.skill hotkey tokens, createSkill util + storage client method).
- 'skill' block alias, entity types/guards, quick-access bucket fed by a
  live soup query, entity icons, and SearchSkills tool renderer.

Generated: openapi/orval schemas, zod, graphql SDL + typegen, DCS tool
schemas, SDK (createSkill wrapper), sqlx query cache, dep closures.
… view

- New ListSkills tool in the skills crate, backed by a soup-service lister
  adapter (access-aware, dst=skill, most recently updated first)
- SkillServiceImpl now composes a searcher and a lister; tool contexts wire
  the soup service in
- doc-skill filter (Type dropdown in the documents view) and skill exclusion
  from the plain-markdown filter
- Skills tab in the agents view with preset, empty state, and a New skill
  create option
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0a8e9356-d979-4945-9a69-6ea814a3423a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

@sedson

sedson commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

bro

@sedson

sedson commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

I think this will need to be a specific component. having the searchable input means that hitting C->D does not even work. It sort of does but it does not close this menu which blows chunks. I think C should still open something the is a specific Launcher (not just command menu) and that thing should be a list not a grid. The hot keys should still work. Maybe there is an opt in input for searching If we need it. It should also have the swaggy animated block icons.

@ehayes2000
ehayes2000 force-pushed the claude/macro-task-review-nbj5xn branch from 069a749 to 54c2ed0 Compare August 5, 2026 16:23
@ehayes2000
ehayes2000 requested a review from a team as a code owner August 5, 2026 16:23
@ehayes2000
ehayes2000 force-pushed the claude/macro-task-review-nbj5xn branch 9 times, most recently from 26fb0fc to bace444 Compare August 6, 2026 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants