Fix SpongeAPI 18 compatibility - #582
Open
Yeregorix wants to merge 3 commits into
Open
Conversation
Previous code was causing an IncompatibleClassChangeError
On Windows it was trying to resolve paths starting with /C:/ resulting in an InvalidPathException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpongeAPI 18 changes:
PluginContributor#name()StandardPluginContainer#candidateis gone and can be replaced byStandardPluginContainer#resource. After seeing your use case I will probably add an API for that in Sponge, so you may not need reflection at all in the future.I also noticed an existing bug that affects all versions:
identifyUrlfails to identify the path for the jar protocol on Windows.