Skip to content

LDEV-6446 Reduce heap when thumbnailing PDFs with large page images #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shane-tw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

LDEV-6446 Reduce heap when thumbnailing PDFs with large page images #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions source/java/src/org/lucee/extension/pdf/util/PDFUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,27 +399,29 @@ public static void thumbnail(PageContext pc, PDFStruct doc, String destination,

CFMLEngine engine = CFMLEngineFactory.getInstance();

PDDocument pdDoc = doc.toPDDocument();
int n = pdDoc.getNumberOfPages();
Iterator<Integer> it = pageNumbers.iterator();
int p;
try (PDDocument pdDoc = doc.toPDDocument()) {
int n = pdDoc.getNumberOfPages();
Iterator<Integer> it = pageNumbers.iterator();
int p;

PDFRenderer pdfRender = new PDFRenderer(pdDoc);
PDFRenderer pdfRender = new PDFRenderer(pdDoc);
pdfRender.setSubsamplingAllowed(true);

while (it.hasNext()) {
p = it.next();
while (it.hasNext()) {
p = it.next();

if (p > n) throw new RuntimeException("pdf page size [" + p + "] out of range, maximum page size is [" + n + "]");
if (p > n) throw new RuntimeException("pdf page size [" + p + "] out of range, maximum page size is [" + n + "]");

// thumbnail image file destination
String imageDestination = destination + "/" + imagePrefix + "_page_" + p + "." + format;
// thumbnail image file destination
String imageDestination = destination + "/" + imagePrefix + "_page_" + p + "." + format;

BufferedImage thumbnailImage = pdfRender.renderImageWithDPI(p - 1, scale);
ByteArrayOutputStream baos = new ByteArrayOutputStream();
ImageIO.write(thumbnailImage, format, baos); // this one not support .tiff format
Resource res = engine.getResourceUtil().toResourceNotExisting(pc, imageDestination);
if (res.exists() && !overwrite) throw new RuntimeException("Thumbnail image file already exists [" + imageDestination + "] and overwrite was false");
engine.getIOUtil().copy(new ByteArrayInputStream(baos.toByteArray()), res, true);
BufferedImage thumbnailImage = pdfRender.renderImageWithDPI(p - 1, scale);
ByteArrayOutputStream baos = new ByteArrayOutputStream();
ImageIO.write(thumbnailImage, format, baos); // this one not support .tiff format
Resource res = engine.getResourceUtil().toResourceNotExisting(pc, imageDestination);
if (res.exists() && !overwrite) throw new RuntimeException("Thumbnail image file already exists [" + imageDestination + "] and overwrite was false");
engine.getIOUtil().copy(new ByteArrayInputStream(baos.toByteArray()), res, true);
}
}
}

Expand Down