Skip to content

add include in cmake lists #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Lixue9jiu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add include in cmake lists #284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dac686c
add include in cmake lists
Lixue9jiu Jul 5, 2026
83d57f7
replace original include
Lixue9jiu Jul 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@ if(HAS_SOCKLEN_T)
add_definitions(-DHAS_SOCKLEN_T=1)
endif()

include_directories(${PROJECT_SOURCE_DIR}/include)

set(INCLUDE_FILES_PREFIX include/enet)
set(INCLUDE_FILES
${INCLUDE_FILES_PREFIX}/callbacks.h
Expand Down Expand Up @@ -104,6 +102,11 @@ add_library(enet
${SOURCE_FILES}
)

target_include_directories(enet
PUBLIC
${PROJECT_SOURCE_DIR}/include
)
Comment on lines +105 to +108

@bjorn bjorn Jul 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a welcome modernization! One suggestion: wrap the path in a BUILD_INTERFACE generator expression. As written it causes no error today because the install(TARGETS enet ...) rule has no EXPORT, but as soon as an export set is added, CMake will fail with "INTERFACE_INCLUDE_DIRECTORIES property contains a path prefixed in the source directory". Adding the generator expressions now costs nothing and keeps that door open (they are supported at the declared CMake 2.8.12 minimum).

Suggested change
target_include_directories(enet
PUBLIC
${PROJECT_SOURCE_DIR}/include
)
target_include_directories(enet PUBLIC
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>
$<INSTALL_INTERFACE:include>
)

This also matches the indentation style used elsewhere in the file, such as the install(TARGETS enet ...) block.


if (WIN32)
target_link_libraries(enet winmm ws2_32)
endif()
Expand Down