Skip to content

[sw,bootrom] Add LED animation on exception #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marnovandermaas merged 3 commits into from
Jun 23, 2026
Merged

[sw,bootrom] Add LED animation on exception #630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c6fd65
[sw, hal] Fix gpio_write_pin
engdoreis Jun 22, 2026
c7c0350
[sw, hal] Add gpio direct port write function
engdoreis Jun 22, 2026
45c848c
[sw,bootrom] Add LED animation on exception
engdoreis Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 34 additions & 6 deletions sw/device/bootrom/bootrom.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
#include <stdint.h>

#define MAJOR "00"
#define MINOR "01"
#define MINOR "02"
#define PATCH "00"
Comment on lines 17 to 19

@ziuziakowska ziuziakowska Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be updated in a different PR, I've also noticed that it doesn't follow the versioning used in https://github.com/lowRISC/mocha/#release-timeline, maybe best to just have it be one string like "v0.2"? I doubt we will be updating the versions frequently enough to need so much granularity.

@marnovandermaas marnovandermaas Jun 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's nice to have this done in this PR so we can make the release.


const uintptr_t boot_slots[] = { 0x10000000, 0x80000000 };
Expand Down Expand Up @@ -56,6 +56,8 @@ int boot_main(void)

timer_init(boot_ctx.timer);
timer_enable_write(boot_ctx.timer, true);
led_init(boot_ctx.gpio);

if (bootstrap_requested(&boot_ctx)) {
uprintf(boot_ctx.console, "Entering SPI bootstrap\n");
clear_slots(); // Cleaning slots from previeous boot.
Expand Down Expand Up @@ -107,8 +109,6 @@ bool get_boot_addr(uint32_t *addr)

bool spi_boot_strap(struct boot_context *ctx)
{
led_init(ctx->gpio);

spi_device_t spid = mocha_system_spi_device();
spi_device_init(spid);
spi_device_enable_set(spid, true);
Expand Down Expand Up @@ -223,9 +223,37 @@ bool bootstrap_requested(struct boot_context *ctx)
return false;
}

// TODO: Catch exceptions properly.
void _trap_handler(struct trap_registers *registers, struct trap_context *context)
static void _exception_handler(struct trap_registers *registers, struct trap_context *context)
{
(void)registers;
(void)context;

uart_t console = mocha_system_uart();
timer_t timer = mocha_system_timer();
gpio_t gpio = mocha_system_gpio();
uart_puts(console, "Exception!\n");
uprintf(console, "\tepc: %lx\n", (unsigned long)context->epc);
uprintf(console, "\tcause: %lx\n", context->cause);
uprintf(console, "\ttval: %lx\n", context->tval);
uprintf(console, "\ttval2: %lx\n", context->tval2);

uint32_t pattern = 0x55;

while (true) {
gpio_write(gpio, pattern);
pattern ^= 0xff;
uint64_t timeout = timer_value_read_us(timer) + led_animation_period_us / 2;
while (timer_value_read_us(timer) < timeout) {
};
};
}
void _trap_handler(struct trap_registers *registers, struct trap_context *context)
{
if (context->cause & (1ul << 63)) {
/* trap cause is interrupt */
while (true) {
};
} else {
/* trap cause is exception */
_exception_handler(registers, context);
}
}
7 changes: 6 additions & 1 deletion sw/device/lib/hal/gpio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,15 @@ bool gpio_read_pin(gpio_t gpio, uint32_t pin)
void gpio_write_pin(gpio_t gpio, uint32_t pin, bool state)
{
uint32_t reg = pin < 16 ? GPIO_REG_MASKED_OUT_LOWER : GPIO_REG_MASKED_OUT_UPPER;
uint32_t mask = 1u << (pin & 0xFu);
uint32_t mask = 1u << ((pin % 16) & 0xFu);
DEV_WRITE(gpio + reg, (mask << 16) | (state ? mask : 0u));
}

void gpio_write(gpio_t gpio, uint32_t val)
{
DEV_WRITE(gpio + GPIO_REG_DIRECT_OUT, val);
}

void gpio_set_oe_pin(gpio_t gpio, uint32_t pin, bool output)
{
uint32_t reg = pin < 16 ? GPIO_REG_MASKED_OE_LOWER : GPIO_REG_MASKED_OE_UPPER;
Expand Down
3 changes: 3 additions & 0 deletions sw/device/lib/hal/gpio.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,8 @@ bool gpio_read_pin(gpio_t gpio, uint32_t pin);
// Set the value of one output pin
void gpio_write_pin(gpio_t gpio, uint32_t pin, bool state);

// Write the value to the output port.
void gpio_write(gpio_t gpio, uint32_t val);

// Set the output enable state of one pin
void gpio_set_oe_pin(gpio_t gpio, uint32_t pin, bool output);