Repository navigation
fix: kooch_physics tests on rapier 0.36 - #1918
Merged
Merged
Conversation
Compare the debug-mode mapping against rapier's flags minus soft bodies, which the engine does not expose. Ignore the voxel seam test in debug builds: rapier 0.36's solver-graph debug check fails on voxels (dimforge/rapier#1029, fix in #1030).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1727
each_category_maps_to_a_rapier_flag: compares againstDebugRenderMode::all()minus the four soft-body flags the engine does not expose; a new rigid flag still breaks it.voxels_have_no_seam_to_snag_on: ignored in debug builds only. Rapier 0.36's debug check of its incremental solver graph fails on voxels — upstream Debug assertion in the incremental solver-contact graph when a ball rolls on a Voxels collider dimforge/rapier#1029, fix in fix: treat voxels pairs as composite in the incremental solver-contact graph dimforge/rapier#1030 (open). Still runs in release; remove theignoreonce a rapier with the fix ships.cargo test -p kooch_physics --lib(with and withoutdebug-render): 223 passed, 1 ignored.