Skip to content

feat: add video tutorial links to the sunset message - #912

Merged
grunch merged 1 commit into
mainfrom
feat/sunset-video-tutorial
Aug 10, 2026
Merged

feat: add video tutorial links to the sunset message#912
grunch merged 1 commit into
mainfrom
feat/sunset-video-tutorial

Conversation

@grunch

@grunch grunch commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

Adds a video tutorial link to the sunset notice introduced in #911:

Test plan

  • npm test — 225 passing; the locale specs in tests/bot/sunset.spec.ts now also assert the tutorial links per language
  • npm run lint clean

Summary by CodeRabbit

  • New Features

    • Added tutorial video links to the sunset messages in English and Spanish.
    • Users can access Mostro guidance directly from these messages.
  • Tests

    • Updated message checks to verify that the tutorial links are included in both languages.

Spanish message links the Spanish tutorial, every other
language links the English one
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The sunset messages now include English and Spanish video tutorial links. Tests define both URLs and verify that each locale message contains the correct link.

Changes

Sunset tutorial links

Layer / File(s) Summary
Localized sunset messages
locales/en.yaml, locales/es.yaml
The English and Spanish sunset messages include language-specific video tutorial URLs.
Sunset message validation
tests/bot/sunset.spec.ts
Tests define both tutorial URLs and verify their inclusion in the matching locale messages.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: matobi98, luquitasjeffrey, catrya

Poem

A rabbit hops through sunset gold,
Two tutorial links unfold.
English here, Spanish there,
Tests check each with careful care.
Squeak—Mostro’s path is bright!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding video tutorial links to the sunset message.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/sunset-video-tutorial

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@grunch
grunch merged commit c8d34fe into main Aug 10, 2026
6 of 7 checks passed
@grunch
grunch deleted the feat/sunset-video-tutorial branch August 10, 2026 22:28

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
tests/bot/sunset.spec.ts (2)

14-15: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Use camelCase for the new test variables.

SPANISH_VIDEO_TUTORIAL and ENGLISH_VIDEO_TUTORIAL are variables. Rename them to spanishVideoTutorial and englishVideoTutorial, then update their references on Lines 95 and 104.

Proposed naming change
-const SPANISH_VIDEO_TUTORIAL = 'https://www.youtube.com/watch?v=lbenPWNlykk';
-const ENGLISH_VIDEO_TUTORIAL = 'https://www.youtube.com/watch?v=Lnyjgecfd_w';
+const spanishVideoTutorial = 'https://www.youtube.com/watch?v=lbenPWNlykk';
+const englishVideoTutorial = 'https://www.youtube.com/watch?v=Lnyjgecfd_w';
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/bot/sunset.spec.ts` around lines 14 - 15, Rename the test constants
SPANISH_VIDEO_TUTORIAL and ENGLISH_VIDEO_TUTORIAL to spanishVideoTutorial and
englishVideoTutorial, and update every reference to use the new camelCase names.

Source: Coding guidelines


95-95: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Add a regression test for the English fallback.

The current assertions cover only the direct Spanish and English locale files. Add one non-English, non-Spanish locale case through the production i18n resolution path and assert that it contains englishVideoTutorial. This verifies the requirement that other locales use the English tutorial link through fallback.

Also applies to: 104-104

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/bot/sunset.spec.ts` at line 95, Add a regression case in the sunset
i18n tests using a non-English, non-Spanish locale through the production
locale-resolution path, then assert its resolved tutorial text contains
englishVideoTutorial. Keep the existing Spanish and English assertions unchanged
and ensure the new case exercises the English fallback rather than directly
loading a locale file.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/bot/sunset.spec.ts`:
- Around line 14-15: Rename the test constants SPANISH_VIDEO_TUTORIAL and
ENGLISH_VIDEO_TUTORIAL to spanishVideoTutorial and englishVideoTutorial, and
update every reference to use the new camelCase names.
- Line 95: Add a regression case in the sunset i18n tests using a non-English,
non-Spanish locale through the production locale-resolution path, then assert
its resolved tutorial text contains englishVideoTutorial. Keep the existing
Spanish and English assertions unchanged and ensure the new case exercises the
English fallback rather than directly loading a locale file.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 48d3c9ca-ec8a-4ff8-acd1-c96a11f7278c

📥 Commits

Reviewing files that changed from the base of the PR and between 2f30650 and fc345d4.

📒 Files selected for processing (3)
  • locales/en.yaml
  • locales/es.yaml
  • tests/bot/sunset.spec.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant