[NVPTX] Add NewPM boilerplate to NVPTXForwardParams - #215141
Open
AlexMaclean wants to merge 2 commits into
Open
Conversation
|
@llvm/pr-subscribers-backend-nvptx Author: Alex MacLean (AlexMaclean) ChangesFull diff: https://github.com/llvm/llvm-project/pull/215141.diff 4 Files Affected:
diff --git a/llvm/lib/Target/NVPTX/NVPTX.h b/llvm/lib/Target/NVPTX/NVPTX.h
index 365ac038b79cc..121e0ec2380c4 100644
--- a/llvm/lib/Target/NVPTX/NVPTX.h
+++ b/llvm/lib/Target/NVPTX/NVPTX.h
@@ -15,6 +15,7 @@
#define LLVM_LIB_TARGET_NVPTX_NVPTX_H
#include "llvm/ADT/Bitfields.h"
+#include "llvm/CodeGen/MachineFunctionAnalysisManager.h"
#include "llvm/IR/PassManager.h"
#include "llvm/Pass.h"
#include "llvm/Support/AtomicOrdering.h"
@@ -59,7 +60,7 @@ FunctionPass *createNVPTXTagInvariantLoadsPass();
FunctionPass *createNVPTXIRPeepholePass();
MachineFunctionPass *createNVPTXPeephole();
MachineFunctionPass *createNVPTXProxyRegErasurePass();
-MachineFunctionPass *createNVPTXForwardParamsPass();
+MachineFunctionPass *createNVPTXForwardParamsLegacyPass();
MachineFunctionPass *createNVPTXAddressFolderPass();
void initializeNVVMReflectLegacyPassPass(PassRegistry &);
@@ -75,7 +76,7 @@ void initializeNVPTXLowerUnreachablePass(PassRegistry &);
void initializeNVPTXLowerArgsLegacyPassPass(PassRegistry &);
void initializeNVPTXPromoteParamAlignLegacyPassPass(PassRegistry &);
void initializeNVPTXProxyRegErasurePass(PassRegistry &);
-void initializeNVPTXForwardParamsPassPass(PassRegistry &);
+void initializeNVPTXForwardParamsLegacyPassPass(PassRegistry &);
void initializeNVPTXAddressFolderPassPass(PassRegistry &);
void initializeNVVMIntrRangePass(PassRegistry &);
void initializeNVVMReflectPass(PassRegistry &);
@@ -136,6 +137,13 @@ struct NVPTXTagInvariantLoadsPass
PreservedAnalyses run(Function &F, FunctionAnalysisManager &AM);
};
+class NVPTXForwardParamsPass
+ : public RequiredPassInfoMixin<NVPTXForwardParamsPass> {
+public:
+ PreservedAnalyses run(MachineFunction &MF,
+ MachineFunctionAnalysisManager &MFAM);
+};
+
namespace NVPTX {
enum DrvInterface {
NVCL,
diff --git a/llvm/lib/Target/NVPTX/NVPTXForwardParams.cpp b/llvm/lib/Target/NVPTX/NVPTXForwardParams.cpp
index d7703fbde48fd..28dc534b1c3df 100644
--- a/llvm/lib/Target/NVPTX/NVPTXForwardParams.cpp
+++ b/llvm/lib/Target/NVPTX/NVPTXForwardParams.cpp
@@ -145,11 +145,13 @@ static bool forwardDeviceParams(MachineFunction &MF) {
/// ----------------------------------------------------------------------------
namespace {
-struct NVPTXForwardParamsPass : public MachineFunctionPass {
+struct NVPTXForwardParamsLegacyPass : public MachineFunctionPass {
static char ID;
- NVPTXForwardParamsPass() : MachineFunctionPass(ID) {}
+ NVPTXForwardParamsLegacyPass() : MachineFunctionPass(ID) {}
- bool runOnMachineFunction(MachineFunction &MF) override;
+ bool runOnMachineFunction(MachineFunction &MF) override {
+ return forwardDeviceParams(MF);
+ }
void getAnalysisUsage(AnalysisUsage &AU) const override {
MachineFunctionPass::getAnalysisUsage(AU);
@@ -157,15 +159,19 @@ struct NVPTXForwardParamsPass : public MachineFunctionPass {
};
} // namespace
-char NVPTXForwardParamsPass::ID = 0;
+char NVPTXForwardParamsLegacyPass::ID = 0;
-INITIALIZE_PASS(NVPTXForwardParamsPass, "nvptx-forward-params",
+INITIALIZE_PASS(NVPTXForwardParamsLegacyPass, "nvptx-forward-params",
"NVPTX Forward Params", false, false)
-bool NVPTXForwardParamsPass::runOnMachineFunction(MachineFunction &MF) {
- return forwardDeviceParams(MF);
+MachineFunctionPass *llvm::createNVPTXForwardParamsLegacyPass() {
+ return new NVPTXForwardParamsLegacyPass();
}
-MachineFunctionPass *llvm::createNVPTXForwardParamsPass() {
- return new NVPTXForwardParamsPass();
+PreservedAnalyses
+NVPTXForwardParamsPass::run(MachineFunction &MF,
+ MachineFunctionAnalysisManager &) {
+ if (!forwardDeviceParams(MF))
+ return PreservedAnalyses::all();
+ return getMachineFunctionPassPreservedAnalyses().preserveSet<CFGAnalyses>();
}
diff --git a/llvm/lib/Target/NVPTX/NVPTXPassRegistry.def b/llvm/lib/Target/NVPTX/NVPTXPassRegistry.def
index 7fd6265cda106..334ffd607c47a 100644
--- a/llvm/lib/Target/NVPTX/NVPTXPassRegistry.def
+++ b/llvm/lib/Target/NVPTX/NVPTXPassRegistry.def
@@ -44,3 +44,9 @@ FUNCTION_PASS("nvptx-mark-kernel-ptrs-global", NVPTXMarkKernelPtrsGlobalPass())
FUNCTION_PASS("nvptx-tag-invariant-loads", NVPTXTagInvariantLoadsPass())
FUNCTION_PASS("nvptx-ir-peephole", NVPTXIRPeepholePass())
#undef FUNCTION_PASS
+
+#ifndef MACHINE_FUNCTION_PASS
+#define MACHINE_FUNCTION_PASS(NAME, CREATE_PASS)
+#endif
+MACHINE_FUNCTION_PASS("nvptx-forward-params", NVPTXForwardParamsPass())
+#undef MACHINE_FUNCTION_PASS
diff --git a/llvm/lib/Target/NVPTX/NVPTXTargetMachine.cpp b/llvm/lib/Target/NVPTX/NVPTXTargetMachine.cpp
index 3c548bc581686..a55df9aca15ac 100644
--- a/llvm/lib/Target/NVPTX/NVPTXTargetMachine.cpp
+++ b/llvm/lib/Target/NVPTX/NVPTXTargetMachine.cpp
@@ -118,7 +118,7 @@ extern "C" LLVM_ABI LLVM_EXTERNAL_VISIBILITY void LLVMInitializeNVPTXTarget() {
initializeNVPTXCtorDtorLoweringLegacyPass(PR);
initializeNVPTXLowerAggrCopiesPass(PR);
initializeNVPTXProxyRegErasurePass(PR);
- initializeNVPTXForwardParamsPassPass(PR);
+ initializeNVPTXForwardParamsLegacyPassPass(PR);
initializeNVPTXAddressFolderPassPass(PR);
initializeNVPTXDAGToDAGISelLegacyPass(PR);
initializeNVPTXAAWrapperPassPass(PR);
@@ -399,7 +399,7 @@ bool NVPTXPassConfig::addInstSelector() {
}
void NVPTXPassConfig::addPreRegAlloc() {
- addPass(createNVPTXForwardParamsPass());
+ addPass(createNVPTXForwardParamsLegacyPass());
if (getOptLevel() != CodeGenOptLevel::None)
addPass(createNVPTXAddressFolderPass());
// Remove Proxy Register pseudo instructions used to keep `callseq_end` alive.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.