Fix button vertical alignment in table cells - #2716
Closed
joshhanley wants to merge 1 commit into
Closed
Conversation
3 tasks
Contributor
|
would be nice to have a comment explaining why leading-0 |
Member
Author
|
Closing as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Scenario
When an inset button with an icon and tooltip is rendered inside a table cell, it can appear vertically offset compared with equivalent buttons without the tooltip or icon.
The Problem
Table cells use
text-sm, which creates an inline line box. Buttons useinline-flex, while buttons with tooltips receive an additional inline tooltip wrapper.When vertical inset applies equal negative margins to the button, the cell's line box continues to use typographic baseline alignment. This causes the remaining vertical space to be distributed unevenly around the button.
The Solution
The solution is to remove the table cell's line-height contribution when it directly contains a button or a tooltip-wrapped button.
The button continues to provide its own height and line height. This allows equal vertical inset margins to reduce the surrounding space symmetrically without changing button width, display behaviour, or ordinary text-only table cells.
This complements #2645, which corrected horizontal alignment for standalone icons in table cells. This change addresses vertical button alignment in those cells.
Fixes #2715