Skip to content

Fix inset and padding on buttons with icons #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ganyicz wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix inset and padding on buttons with icons #2695

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6fb9331
Fix asymmetric padding on buttons with icons
ganyicz Jul 21, 2026
0269db2
Fix
ganyicz Jul 21, 2026
bbbcf9e
Fix
ganyicz Jul 21, 2026
eda33c4
Fix
ganyicz Jul 22, 2026
d99c261
Fix
ganyicz Jul 22, 2026
6af1f16
Fix
ganyicz Jul 22, 2026
eb38578
Update index.blade.php
ganyicz Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions stubs/resources/views/flux/button/index.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,34 +62,42 @@
}

$classes = Flux::classes()
->add('relative items-center font-medium justify-center gap-2 whitespace-nowrap')
->add('relative items-center font-medium justify-center whitespace-nowrap')
->add('disabled:opacity-75 dark:disabled:opacity-75 disabled:cursor-default disabled:pointer-events-none')
->add(match ($align) {
'start' => 'justify-start',
'center' => 'justify-center',
'end' => 'justify-end',
})
->add(match ($size) { // Size...
'base' => 'h-10 text-sm rounded-lg' . ' ' . (
'base' => 'h-10 text-sm rounded-lg gap-2' . ' ' . (
$square
? 'w-10'
// If we have an icon, we want to reduce the padding on the side that has the icon...
: ($iconLeading && $iconLeading !== '' ? 'ps-3' : 'ps-4') . ' ' . ($iconTrailing && $iconTrailing !== '' ? 'pe-3' : 'pe-4')
),
'sm' => 'h-8 text-sm rounded-md' . ' ' . ($square ? 'w-8' : 'px-3'),
'xs' => 'h-6 text-xs rounded-md' . ' ' . ($square ? 'w-6' : 'px-2'),
'sm' => 'h-8 text-sm rounded-md gap-2' . ' ' . (
$square
? 'w-8'
: ($iconLeading && $iconLeading !== '' ? 'ps-2' : 'ps-3') . ' ' . ($iconTrailing && $iconTrailing !== '' ? 'pe-2' : 'pe-3')
),
'xs' => 'h-6 text-xs rounded-md gap-1' . ' ' . (
$square
? 'w-6'
: ($iconLeading && $iconLeading !== '' ? 'ps-1' : 'ps-2') . ' ' . ($iconTrailing && $iconTrailing !== '' ? 'pe-1' : 'pe-2')
),
})
->add('inline-flex') // Buttons are inline by default but links are blocks, so inline-flex is needed here to ensure link-buttons are displayed the same as buttons...
->add($inset ? match ($size) { // Inset...
'base' => $square
? Flux::applyInset($inset, top: '-mt-2.5', right: '-me-2.5', bottom: '-mb-2.5', left: '-ms-2.5')
: Flux::applyInset($inset, top: '-mt-2.5', right: '-me-4', bottom: '-mb-3', left: '-ms-4'),
: Flux::applyInset($inset, top: '-mt-2.5', right: ($iconTrailing && $iconTrailing !== '' ? '-me-3' : '-me-4'), bottom: '-mb-3', left: ($iconLeading && $iconLeading !== '' ? '-ms-3' : '-ms-4')),
'sm' => $square
? Flux::applyInset($inset, top: '-mt-1.5', right: '-me-1.5', bottom: '-mb-1.5', left: '-ms-1.5')
: Flux::applyInset($inset, top: '-mt-1.5', right: '-me-3', bottom: '-mb-1.5', left: '-ms-3'),
: Flux::applyInset($inset, top: '-mt-1.5', right: ($iconTrailing && $iconTrailing !== '' ? '-me-2' : '-me-3'), bottom: '-mb-1.5', left: ($iconLeading && $iconLeading !== '' ? '-ms-2' : '-ms-3')),
'xs' => $square
? Flux::applyInset($inset, top: '-mt-1', right: '-me-1', bottom: '-mb-1', left: '-ms-1')
: Flux::applyInset($inset, top: '-mt-1', right: '-me-2', bottom: '-mb-1', left: '-ms-2'),
: Flux::applyInset($inset, top: '-mt-1', right: ($iconTrailing && $iconTrailing !== '' ? '-me-1' : '-me-2'), bottom: '-mb-1', left: ($iconLeading && $iconLeading !== '' ? '-ms-1' : '-ms-2')),
} : '')
->add(match ($variant) { // Background color...
'primary' => 'bg-[var(--color-accent)] hover:bg-[color-mix(in_oklab,_var(--color-accent),_transparent_10%)]',
Expand Down