fix: guard nil externalWorkload in opaque protocol computation (#15551) - #15552
Open
waterWang wants to merge 1 commit into
Open
fix: guard nil externalWorkload in opaque protocol computation (#15551)#15552waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
adleong
approved these changes
Aug 4, 2026
adleong
left a comment
Member
There was a problem hiding this comment.
Great catch and thanks for this fix! Please agree to the DCO as described in https://github.com/linkerd/linkerd2/blob/main/CONTRIBUTING.md#developer-certificate-of-origin so that we can accept this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
submitExternalWorkloadUpdateis called withremove=true(workload deletion), it passesniltoupdateExternalWorkload. The function then callsSetToServerProtocolExternalWorkloadand logs an error message that dereferenceswp.addr.ExternalWorkload.GetName()— butExternalWorkloadisnilat that point, causing a panic.Fix
Guard the opaque protocol computation and error log with a nil check on
externalWorkload. When the workload is being deleted (nil), there is no opaque protocol to compute, and the listeners are still notified of the empty address.Stack trace from the bug
Testing
controller/api/destination/watcher/continue to pass since the change only adds a nil guard that is a no-op for non-nil inputs.Closes #15551