masonry: add hover and press highlight to Button#1829
Open
emnrdl wants to merge 1 commit into
Open
Conversation
Button::pre_paint now overlays a translucent highlight ring when the button is hovered, pressed, or focused, so every button gives pointer feedback regardless of its background and border colors. This mirrors the hover/focus indicator already drawn by Checkbox. Signed-off-by: emnrdl <emnrdl@gmail.com>
emnrdl
force-pushed
the
button-hover-highlight
branch
from
June 21, 2026 19:23
3384e67 to
8670d00
Compare
Contributor
|
Sorry, I've been busy, hoping to review this soon! |
PoignardAzur
requested changes
Jul 3, 2026
PoignardAzur
left a comment
PoignardAzur
left a comment
Contributor
There was a problem hiding this comment.
I might be missing something, but I think this is the wrong direction. This year we've started to move away from custom status-checking code in widgets, towards using conditional properties instead. This seems like a move in the opposite direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Button::pre_paint now overlays a translucent highlight ring when the button is hovered, pressed, or focused, so every button gives pointer feedback regardless of its background and border colors. This mirrors the hover/focus indicator already drawn by Checkbox.