Tweak Spinner#1825
Open
BrianCraig wants to merge 1 commit into
Open
Conversation
BrianCraig
force-pushed
the
spinner-tweak
branch
from
June 15, 2026 21:30
c0dfc6f to
8d3dcde
Compare
Tweaked `Spinner` look and feel, to a rolling semi-circle arc, which now uses `TrackColor` and `TrackThickness`, and a new `AnimationDuration` property. Overall: - Modified `spinner.rs` regarding its render and animation, updated current harness tests, added two simple harness tests for thickness and colors, removed `edit_spinner` test since the Widget always re-render and does not need to check for property changes. - Moved `TrackColor` and `TrackThickness` property definitions from `slider.rs` to a new `track.rs`. - Created `AnimationDuration` property. - Updated the gallery example, with tools to check different sizes, thickness, speed and colors. - Updated `divider_content.png` to its new harness result. One important note is that `Spinner` stops to use the `ContentColor` property migrating to `TrackColor`, this can cause problems since `Spinner` now does not `impl UsesProperty<ContentColor>`. Disclaimer: Gallery Spinner code was partially written with help of AI providing context of another section of the gallery, all other code parts are written by me.
BrianCraig
force-pushed
the
spinner-tweak
branch
from
June 15, 2026 21:42
8d3dcde to
5b05337
Compare
PoignardAzur
self-requested a review
June 18, 2026 10:36
Contributor
|
Thanks for the PR! I haven't been available lately, but I'll take a look soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This is my first contributtion.
Tweaked
Spinnerlook and feel, to a rolling semi-circle arc, which now usesTrackColorandTrackThickness, and a newAnimationDurationproperty. Overall:spinner.rsregarding its render and animation, updated current harness tests, added two simple harness tests for thickness and colors, removededit_spinnertest since the Widget always re-render and does not need to check for property changes.TrackColorandTrackThicknessproperty definitions fromslider.rsto a newtrack.rs.AnimationDurationproperty.divider_content.pngto its new harness result.One important note is that
Spinnerstops to use theContentColorproperty migrating toTrackColor, this can cause problems sinceSpinnernow does notimpl UsesProperty<ContentColor>.Disclaimer: Gallery Spinner code was partially written with help of AI providing context of another section of the gallery, all other code parts are written by me.
2026-06-15.12-50-04.mp4