vello_common: compute the transparency hint in ImageSource::from_peniko_image_data#1760
Queued
tronical wants to merge 1 commit into
Queued
vello_common: compute the transparency hint in ImageSource::from_peniko_image_data#1760tronical wants to merge 1 commit into
tronical wants to merge 1 commit into
Conversation
…ko_image_data The conversion built the Pixmap via from_parts(), which conservatively marks every image as possibly transparent. As a result, images supplied as peniko::ImageData never hit the FillHint::OpaqueImage fast path in the coarse rasterizer (skipping per-pixel blending and occluding commands underneath), even when they are fully opaque. The conversion already visits every pixel to premultiply, so track whether any alpha value is not 255 in the same loop and construct the Pixmap with from_parts_with_opacity().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conversion built the Pixmap via from_parts(), which conservatively marks every image as possibly transparent. As a result, images supplied as peniko::ImageData never hit the FillHint::OpaqueImage fast path in the coarse rasterizer (skipping per-pixel blending and occluding commands underneath), even when they are fully opaque.
The conversion already visits every pixel to premultiply, so track whether any alpha value is not 255 in the same loop and construct the Pixmap with from_parts_with_opacity().
This PR was done with assistance of Claude Code.