Add BlurredRoundedRectangle - #173
Open
PoignardAzur wants to merge 2 commits into
Open
Conversation
Copy-pasted from vello_common.
waywardmonkeys
left a comment
Collaborator
There was a problem hiding this comment.
This is an interesting one ...
In anyrender, it transports the transform along with it:
pub struct BoxShadowCommand {
pub transform: Affine,
pub rect: Rect,
pub brush: Color,
pub radius: f64,
pub std_dev: f64,
}In imaging, it does as well and includes a composite:
/// A solid-color rounded rectangle blurred with a gaussian filter.
#[derive(Copy, Clone, Debug, PartialEq)]
pub struct BlurredRoundedRect {
/// Geometry transform.
pub transform: Affine,
/// Unblurred rectangle bounds.
pub rect: Rect,
/// Solid color used by the blurred rectangle.
pub color: peniko::Color,
/// Uniform corner radius in user-space units.
pub radius: f64,
/// Gaussian standard deviation in user-space units.
pub std_dev: f64,
/// Per-draw compositing.
pub composite: Composite,
}Obviously, we could use this to store the 4 fields as a single shared structure definition, but that wouldn't necessarily make the API better / different.
Not sure.
Member
|
@waywardmonkeys I could see that being useful/convenient for serializing or for lowering into renderers without the specialization (likely a straight copy, rather than a manual swizzle). In that sense it would be ‘better’ in at least that way. |
Contributor
Author
|
I think vello_common's version makes the most sense for peniko.
|
PoignardAzur
force-pushed
the
blurred_rect
branch
from
June 9, 2026 07:37
5638dff to
c7fa856
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy-pasted from vello_common.