Add new UiShape type - #172
Open
PoignardAzur wants to merge 1 commit into
Open
Conversation
Implement Shape for that type. Based on linebender#165 by @waywardmonkeys.
waywardmonkeys
left a comment
waywardmonkeys
left a comment
Collaborator
There was a problem hiding this comment.
I don't know where I'd use this. I wouldn't use it for clips as I want something that is specifically for clips (and I wouldn't want an impl Shape for it). Other things have differing sets of "shapes" that they support or would find useful, so generalizing this to a UiShape doesn't feel like the right thing to me.
Contributor
Author
That seems a bit arbitrary? It's the exact same type as the one in your PR, with the same variants, just under a different name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Shape for that type.
Based on #165 by @waywardmonkeys.