Repository navigation
hy-emit(rangebind): preserve outer bindings projected in same-name range hi bounds (fixes #3826) - #4450
Open
SuperPiIot wants to merge 1 commit into
Open
hy-emit(rangebind): preserve outer bindings projected in same-name range hi bounds (fixes #3826)#4450SuperPiIot wants to merge 1 commit into
SuperPiIot wants to merge 1 commit into
Conversation
…nge hi bounds (fixes limitlessprojects#3826)
github-actions
Bot
added
the
bot:land-candidate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3826\n\n### Summary\n- In
compiler/crates/hy-emit/src/rangebind.rs(stmt_reads), addexpr_projects_target(hi, target)so an innerfor <var> in lo..hiwhosehiprojects<var>viaExpr::Index,Expr::Field, orExpr::Slice(0..a[0],0..it.n,0..xs[i]) counts as reading the outer<var>binding.\n- Preserving the outer binding keepsvar_in_scope == trueinEmitter::emit_for, hoistinghyHi := hibefore the loop header acrossfor,match, andselectscopes while keeping barefor v in 0..vblanking intact.\n- Adds regression coverage incompiler/crates/hy-emit/tests/rangebind_projected_same_name_hi.rs.\n\nCloses #3826\n/claim #3826\n\n### Payout Wallet\nBase (USDC): 0xf084cF0076F91AA48C2370F427C399dAA8C1f07F