Repository navigation
fix(tools): fail closed on missing managed report for accepted programs (fixes #3251) - #4321
Open
gorky117-cell wants to merge 2 commits into
Conversation
…ms (fixes limitlessprojects#3251) - In tools/corpus_harness.py run_checker(), when --report-managed is requested, require that accepted programs carry a non-null summary.managed report. - Previously, missing reports on otherwise accepted verdicts were treated as empty and aggregated as zero counters, conflating missing audit measurement with measured zero managed blocks. - Preserves parse failure exemptions where no managed report is expected. - Add test coverage in test_corpus_harness.py verifying absent and null managed reports on accepted programs fail closed with harness error. Signed-off-by: Gaurav Kumar Singh <gauravatwork117@gmail.com>
gorky117-cell
force-pushed
the
fix/issue-3251-corpus-harness-missing-managed-report
branch
from
November 10, 2026 23:17
0dddc43 to
4f47332
Compare
…into fix/issue-3251-corpus-harness-missing-managed-report Signed-off-by: gauravatwork117 <gauravatwork117@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #3251 by ensuring that
tools/corpus_harness.pyfails closed when an accepted program omits a requestedsummary.managedreport:--report-managedwas passed,run_checker()only validatedsummary.managedif the field was present (if managed is not None:).acceptverdict lacking that field, the aggregation loop treated the missing report as empty ({}) and counted zero blocks/sites, conflating a missing audit report with a measured zero.--report-managedis active, an accepted program must emit a non-nullsummary.managedobject.Verification & Tests
test_missing_or_null_report_on_accept_fails_closedtoManagedReportCliTestsintools/test_corpus_harness.py:nullreports onACCEPTverdicts fail closed with a harness error (returncode == 1).REJECTparser error fixtures without a managed report continue to pass without error.Signed-off-by: Gaurav Kumar Singh gauravatwork117@gmail.com