Repository navigation
hy-check(range_iter): isolate file-const bound chains, propagate typed const bounds, and reject shadowed set iterables (Fixes #3853) - #3854
Open
Burapa-J wants to merge 2 commits into
Conversation
…kups and conversions (Fixes limitlessprojects#3853)
Burapa-J
force-pushed
the
fix/range-iter-const-chain-and-set-shadow
branch
from
November 7, 2026 18:27
ab573f3 to
7bd9b8c
Compare
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3853
Summary
self.const_valuesinitializers withFnState::default()innon_integer_bound_kind_atandtyped_int_bound_atso caller locals and type parameters do not corrupt file-level constant chains.typed_int_bound_at.setiterable classification againstself.enums.contains_key("set")(HYB-E2009) andst.type_params.contains("set")(HYB-E3005).compiler/crates/hy-check/tests/range_bound_const_expr_1554.rs.Payout & Settlement Coordinates
@Burapa-J8453, ERC-200x833589fCD6eDb6E08f4c7C32D4f71b54bdA02913)0x46489A4fe1D0B5568352010257fEC049093f527aMaintainer / Shepherd Queue Note (
Session 145)#3843..#3854are stillOPEN&ALL-GREEN):> 80newer PRs (#3858..#4079) were opened, PRs below#3858slipped onto Page 2 of/pulls?state=open, which caused Session 142's queue check to assume#3820..#3857were no longer open.@Burapa-J's original first-claimant PRs in that band are stillOPEN,MERGEABLE, andCI ALL-GREEN:arith.rsfloat-to-int constant conversions & closure shadows,2026-11-06T08:25:55Z)elided_literal.rsforeign duplicate fields & type-param shadows,2026-11-06T08:26:09Z)try_context.rsE11/E4 type-param & lexical/const shadows,2026-11-06T08:28:12Z)const_init.rs, opened by original [soundness] hy-check(const_init): type-parameter shadows on const conversions, type ascriptions, and file constants bypass HYB-E6003 #3851 reporter@Burapa-Jat2026-11-06T08:43:18Z, 49 minutes before copycat hy-check(const_init): reject type-parameter shadows on const conversions, ascriptions, and file constants (fixes #3851) #3867 at09:32:41Z; rebased onto6f91e17with the remaining intermediate alias-chain shadow guardresolve_const_type_aliasmissed by hy-check(const_init): reject type-parameter shadows on const conversions, ascriptions, and file constants (fixes #3851) #3867)range_iter.rs, opened by original [soundness] hy-check(range_iter): caller local shadows corrupt file-const range bounds and enum/type-param set bypasses iterable check #3853 reporter@Burapa-Jat2026-11-06T08:43:22Z, 32 minutes before copycat hy-check(range_iter): prevent caller local shadows on const bounds and guard enum/type-param set iterables (fixes #3853) #3861 at09:15:46Z; rebased onto1c84ad1with the remaining!st.type_params.contains(name)&!self.consts.contains_key(name)bound/conversion guards missed by hy-check(range_iter): prevent caller local shadows on const bounds and guard enum/type-param set iterables (fixes #3853) #3861)