-
Notifications
You must be signed in to change notification settings - Fork 97
LCORE-2505: Add migration guide and deprecation notes for BYOK config refactoring #1882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| # Migrating to v0.7.0 | ||
|
|
||
| ## Table of Contents | ||
|
|
||
| * [RAG Configuration](#rag-configuration) | ||
|
|
||
| --- | ||
|
|
||
| ## RAG Configuration | ||
|
|
||
| In v0.7.0, the RAG configuration in `lightspeed-stack.yaml` is unified under a single `rag` section. The four separate top-level sections (`byok_rag`, `rag`, `okp`, `reranker`) are replaced by a nested structure that groups BYOK stores, OKP settings, retrieval strategies, and reranker settings together. The `rag_type` field is renamed to `backend` and the `inline::`/`remote::` prefix is dropped (e.g. `inline::faiss` becomes `faiss`). Hardcoded chunk limit constants are now user-configurable fields with sensible defaults. | ||
|
|
||
| ### Field Mapping | ||
|
|
||
| | Old config path | New config path | Notes | | ||
| |---|---|---| | ||
| | `byok_rag` (top-level list) | `rag.byok.stores` | Moved under `rag.byok` | | ||
| | `byok_rag[].rag_type` | `rag.byok.stores[].backend` | Drop the `inline::`/`remote::` prefix (e.g. `inline::faiss` becomes `faiss`) | | ||
| | `rag.inline` (list of IDs) | `rag.retrieval.inline.sources` | Moved under `rag.retrieval.inline` | | ||
| | `rag.tool` (list of IDs) | `rag.retrieval.tool.sources` | Moved under `rag.retrieval.tool` | | ||
| | `okp` (top-level section) | `rag.okp` | Moved under `rag` | | ||
| | `BYOK_RAG_MAX_CHUNKS` constant | `rag.byok.max_chunks` | Default: 10 | | ||
| | `OKP_RAG_MAX_CHUNKS` constant | `rag.okp.max_chunks` | Default: 5 | | ||
| | `INLINE_RAG_MAX_CHUNKS` constant | `rag.retrieval.inline.max_chunks` | Default: 10 | | ||
| | `TOOL_RAG_MAX_CHUNKS` constant | `rag.retrieval.tool.max_chunks` | Default: 10 | | ||
| | `reranker` (top-level section) | `rag.retrieval.inline.reranker` | Moved under `rag.retrieval.inline` | | ||
|
|
||
| --- | ||
|
|
||
| ### Before / After Examples | ||
|
|
||
| #### Full RAG Configuration Example | ||
|
|
||
| **Before (v0.6.x):** | ||
|
|
||
| ```yaml | ||
| byok_rag: | ||
| - rag_id: ocp-docs | ||
| rag_type: inline::faiss | ||
| embedding_model: sentence-transformers/all-mpnet-base-v2 | ||
| embedding_dimension: 768 | ||
| vector_db_id: vs_123 | ||
| db_path: /tmp/ocp.faiss | ||
| score_multiplier: 1.0 | ||
| - rag_id: knowledge-base | ||
| rag_type: inline::faiss | ||
| embedding_model: sentence-transformers/all-mpnet-base-v2 | ||
| embedding_dimension: 768 | ||
| vector_db_id: vs_456 | ||
| db_path: /tmp/kb.faiss | ||
| score_multiplier: 1.2 | ||
|
|
||
| rag: | ||
| inline: | ||
| - ocp-docs | ||
| - knowledge-base | ||
| - okp | ||
| tool: | ||
| - ocp-docs | ||
| - knowledge-base | ||
|
|
||
| okp: | ||
| rhokp_url: ${env.RH_SERVER_OKP} | ||
| offline: true | ||
| # chunk_filter_query: "product:*ansible* AND product:*openshift*" | ||
|
|
||
| reranker: | ||
| enabled: true | ||
| model: cross-encoder/ms-marco-MiniLM-L6-v2 | ||
| ``` | ||
|
|
||
| **After (v0.7.0):** | ||
|
|
||
| ```yaml | ||
| rag: | ||
| byok: | ||
| max_chunks: 10 # Was BYOK_RAG_MAX_CHUNKS constant | ||
| stores: | ||
| - rag_id: ocp-docs | ||
| backend: faiss # Was 'rag_type: inline::faiss' | ||
| embedding_model: sentence-transformers/all-mpnet-base-v2 | ||
| embedding_dimension: 768 | ||
| vector_db_id: vs_123 | ||
| db_path: /tmp/ocp.faiss | ||
| score_multiplier: 1.0 | ||
| - rag_id: knowledge-base | ||
| backend: faiss # Was 'rag_type: inline::faiss' | ||
| embedding_model: sentence-transformers/all-mpnet-base-v2 | ||
| embedding_dimension: 768 | ||
| vector_db_id: vs_456 | ||
| db_path: /tmp/kb.faiss | ||
| score_multiplier: 1.2 | ||
|
|
||
| okp: | ||
| rhokp_url: ${env.RH_SERVER_OKP} | ||
| offline: true | ||
| max_chunks: 5 # Was OKP_RAG_MAX_CHUNKS constant | ||
| # chunk_filter_query: "product:*ansible* AND product:*openshift*" | ||
|
|
||
| retrieval: | ||
| inline: | ||
| sources: | ||
| - ocp-docs | ||
| - knowledge-base | ||
| - okp | ||
| max_chunks: 10 # Was INLINE_RAG_MAX_CHUNKS constant | ||
| reranker: | ||
| enabled: true | ||
| model: cross-encoder/ms-marco-MiniLM-L6-v2 | ||
| tool: | ||
| sources: | ||
| - ocp-docs | ||
| - knowledge-base | ||
| max_chunks: 10 # Was TOOL_RAG_MAX_CHUNKS constant | ||
| ``` | ||
|
|
||
| --- | ||
|
|
||
| ### Chunk Limits | ||
|
|
||
| Chunk limits were previously hardcoded as constants in `src/constants.py`. They are now configurable fields in `lightspeed-stack.yaml` with the same default values: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Chunk limits have been moved from constants in the code to configurable fields in lightspeed-stack.yaml. The default values of the fields match the previous constants."
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Verb tense is wrong,
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed the verb tenses over the docs, are you confused by something else? What it means is that the old constants become configurable in the lightspeed config, and the defaults are unchanged.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's all good, I just thought why mention a file with code in user-facing docs. |
||
|
|
||
| | Old constant | New config field | Default | | ||
| |---|---|---| | ||
| | `BYOK_RAG_MAX_CHUNKS` | `rag.byok.max_chunks` | 10 | | ||
| | `OKP_RAG_MAX_CHUNKS` | `rag.okp.max_chunks` | 5 | | ||
| | `INLINE_RAG_MAX_CHUNKS` | `rag.retrieval.inline.max_chunks` | 10 | | ||
| | `TOOL_RAG_MAX_CHUNKS` | `rag.retrieval.tool.max_chunks` | 10 | | ||
Uh oh!
There was an error while loading. Please reload this page.