Skip to content

waved: export Taproot Asset runtime registration#1037

Open
darioAnongba wants to merge 1 commit into
feat/taproot-assets-carrier-selectionfrom
feat/taproot-assets-runtime-registration
Open

waved: export Taproot Asset runtime registration#1037
darioAnongba wants to merge 1 commit into
feat/taproot-assets-carrier-selectionfrom
feat/taproot-assets-runtime-registration

Conversation

@darioAnongba

Copy link
Copy Markdown
Collaborator

Summary

  • move the production tapd/tap-sdk runtime registrar from cmd/waved into an exported waved.ConfigureTaprootAssets helper
  • let embedded consumers such as the Lumos integration harness install exactly the same credential, journal, reservation, OOR preparation, onboarding, and shutdown lifecycle
  • keep the standalone command as a thin delegate
  • make registration idempotent per daemon Config and preserve pre-injected preparer ownership

This is a small parallel follow-up to #1035. It changes no Taproot Asset transaction behavior; it exposes the existing production wiring at the library boundary needed by embedded Wavelength deployments.

Validation

  • go test ./waved ./cmd/waved
  • focused race tests
  • make build
  • make lint-changed-local
  • make fmt-changed-check
  • make tidy-module-check
  • commit-message lint

A live tapd startup is covered by the later Lumos end-to-end branch; this refactor preserves the existing lazy registrar and cleanup implementation.

Let embedded consumers install the same lazy tapd-backed OOR and
onboarding runtime as the standalone daemon without duplicating
credentials or lifecycle wiring.
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

return closeWallet, nil
},
)
waved.ConfigureTaprootAssets(cfg)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: let's remove configureTaprootAssets function altogether and just call waved.ConfigureTaprootAssets(cfg)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants