Add types for read_yolo_label_file.py - #2046
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe mypy configuration no longer excludes ChangesMypy coverage update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This narrowly enables continuous type checking for an already annotated file and introduces no actionable merge-blocking risk beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Remove
read_yolo_label_file.pyfrom the mypy exclusion list. The file is already fully annotated, so this brings it under continuous type checking and prevents future type regressions.Part of #1635.
Checks
mypy 1.4.1 lightly/utils/cropping/read_yolo_label_file.pyruff 0.12.7 check lightly testsruff 0.12.7 format --check lightly testsgit diff --checkRemoves
read_yolo_label_file.pyfrom the mypy exclusion list. This adds continuous type-checking coverage for the file.