Skip to content

[BugFix] Skip TestGatherLayer_Losses on macOS #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RecreationalMath wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[BugFix] Skip TestGatherLayer_Losses on macOS #1922

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c76f26
Skip TestGatherLayer_Losses on macOS
RecreationalMath May 7, 2026
d4fcab5
Merge branch 'master' into macos-test-fast
RecreationalMath May 18, 2026
a233235
Merge branch 'master' into macos-test-fast
gabrielfruet May 19, 2026
b78ad7c
Merge branch 'master' into macos-test-fast
gabrielfruet May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tests/utils/test_dist__gather__losses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import os
import sys
from typing import Any, Generator, Tuple, Type

import pytest
Expand Down Expand Up @@ -63,8 +64,11 @@ def close_torch_distributed() -> Generator[None, None, None]:


@pytest.mark.skipif(
os.getenv("GITHUB_ACTIONS") is not None,
reason="This test is running in parallel and breaks codecov",
os.getenv("GITHUB_ACTIONS") is not None or sys.platform == "darwin",
reason=(
"Skipped on GitHub Actions due to codecov interaction and "
"on macOS due to DDPStrategy spawn deadlock."
),
)
class TestGatherLayer_Losses:
"""Tests that the gather layer works as expected.
Expand Down
Loading