-
Notifications
You must be signed in to change notification settings - Fork 784
fix(codex): keep pre-connection DNS/network failures off account health (#914) #966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Yuxin-Qiao
wants to merge
5
commits into
lidge-jun:dev
from
Yuxin-Qiao:codex/260804-issue914-transport-attribution
Closed
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fe693ae
fix(codex): keep pre-connection DNS/network failures off account heal…
Yuxin-Qiao 80cd0ce
fix(codex): address #914 review blockers (5xx evidence, sidecar redir…
Yuxin-Qiao 71bd821
fix(codex): manual redirects for all credential-bearing forward sends…
Yuxin-Qiao 78c824d
fix(codex): carry reset evidence and scope manual redirects (#914)
Yuxin-Qiao bd55f1a
fix(codex): fail closed on cleartext-http credential sends (#914)
Yuxin-Qiao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Preserve the “proven” classification qualifier in every translation.
The English source limits neutral handling to proven pre-connection DNS/TCP reachability failures. Without that qualifier, these translations imply that every apparent pre-connection failure is neutral. Unknown failures must remain account-attributed.
docs-site/src/content/docs/ja/reference/configuration/providers.md#L24-L24: State that the DNS/TCP reachability failure must be confirmed or proven.docs-site/src/content/docs/ko/reference/configuration/providers.md#L24-L24: State that the DNS/TCP reachability failure must be confirmed or proven.docs-site/src/content/docs/zh-cn/reference/configuration/providers.md#L24-L24: State that the DNS/TCP reachability failure must be confirmed or proven.As per path instructions, translated locale pages must not contradict the English source.
📍 Affects 3 files
docs-site/src/content/docs/ja/reference/configuration/providers.md#L24-L24(this comment)docs-site/src/content/docs/ko/reference/configuration/providers.md#L24-L24docs-site/src/content/docs/zh-cn/reference/configuration/providers.md#L24-L24🤖 Prompt for AI Agents
Source: Path instructions