Skip to content

fix(zai): complete GLM-5.3 coding metadata - #1762

Merged
lidge-jun merged 1 commit into
devfrom
ingw/fix-zai-glm53-metadata-1734
Aug 15, 2026
Merged

fix(zai): complete GLM-5.3 coding metadata#1762
lidge-jun merged 1 commit into
devfrom
ingw/fix-zai-glm53-metadata-1734

Conversation

@Ingwannu

@Ingwannu Ingwannu commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • set the documented default reasoning effort for zai/glm-5.3 and zai/glm-5.3[1m] to max
  • set the documented per-model maximum output to 128,000 tokens
  • verify registry seeding, key-login derivation, routing, and catalog default metadata

Scope

This change is limited to the Z.AI Coding Plan route. It does not infer GLM-5.3 availability or metadata for unrelated pay-as-you-go or aggregator endpoints.

Validation

  • bun test tests/provider-registry-parity.test.ts (37 passed)
  • bun run typecheck
  • bun run privacy:scan
  • git diff --check

Fixes #1734

Summary by CodeRabbit

  • New Features

    • GLM-5.3 models, including the [1m] variant, now default to maximum reasoning effort.
    • Increased the maximum generated output to 131,072 tokens (128K).
  • Bug Fixes

    • Provider routing and model catalog entries now consistently reflect the updated reasoning and output limits.

@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Aug 15, 2026
@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6652e7a7-d21d-4f58-8ecc-06a84421331d

📥 Commits

Reviewing files that changed from the base of the PR and between 5f55cd8 and ad89bc0.

📒 Files selected for processing (2)
  • src/providers/registry.ts
  • tests/provider-registry-parity.test.ts

📝 Walkthrough

Walkthrough

The Z.AI registry assigns max reasoning effort and a 131,072-token output limit to GLM-5.3 variants. Provider parity tests verify propagation through provider configuration, routing, key-login derivation, and catalog generation.

Changes

Z.AI GLM-5.3 metadata

Layer / File(s) Summary
Registry defaults and metadata propagation
src/providers/registry.ts, tests/provider-registry-parity.test.ts
The registry defines max as the default reasoning effort and 131,072 as the maximum output-token limit for glm-5.3 and glm-5.3[1m]. Tests verify propagation through provider configuration, routing, key-login derivation, bracket suffix stripping, and generated catalog entries.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: provider

Suggested reviewers: lidge-jun, wibias

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Z.AI GLM-5.3 Coding Plan metadata fix, which is the primary change.
Linked Issues check ✅ Passed The registry and parity tests add max reasoning and 128,000-token output metadata for both GLM-5.3 Coding Plan aliases and verify propagation.
Out of Scope Changes check ✅ Passed The changes are limited to Z.AI registry metadata and focused parity tests required by issue #1734.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ingw/fix-zai-glm53-metadata-1734

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The GLM-5.3 entries carried the shared 5.x reasoning ladder but no default
effort and no output budget, so routed callers fell back to the provider
default instead of the model's real ceiling.

Record the published default effort and output budget for both the plain and
bracketed ids. The output budget is 131_072, matching the generated model
metadata and every other GLM-5.x entry in this repository, rather than the
rounded '128K' the vendor page prints; pricing stays unasserted because the
Coding Plan rate is still unpublished.

Closes #1734
Co-authored-by: Ingwannu <ingwannu@users.noreply.github.com>
@lidge-jun
lidge-jun force-pushed the ingw/fix-zai-glm53-metadata-1734 branch from 5f55cd8 to ad89bc0 Compare August 15, 2026 13:22
@lidge-jun
lidge-jun merged commit 8dcb834 into dev Aug 15, 2026
7 of 8 checks passed
@Wibias
Wibias deleted the ingw/fix-zai-glm53-metadata-1734 branch August 15, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants