fix(cursor): preserve unified exec in generic tool filtering - #1673
fix(cursor): preserve unified exec in generic tool filtering#1673Ingwannu wants to merge 1 commit into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughCursor generic tool handling now recognizes unified Desktop ChangesCursor unified exec bridge
Estimated code review effort: 3 (Moderate) | ~15 minutes Merge Risk: ⚪ Minimal · up to This localized Cursor tool-filtering fix preserves unified execution behavior and keeps legacy guidance appropriately gated; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lidge-jun
left a comment
There was a problem hiding this comment.
[Repository bug audit · 2026-08-14]
The reviewed logic is sound: generic tool-use filtering now recognizes every Cursor execution-path tool, preserves unified Desktop exec, keeps legacy alias guidance conditional on an alias actually being present, and routes execution back through the Responses client-tool suspension path rather than native local exec.
This PR is currently not mergeable against dev. Rebase onto the latest dev, resolve only the tool-definition/continuation overlap, and rerun the full tests/cursor-*.test.ts set plus typecheck. Do not fold the larger structured-edit work from #1634 into this focused fix.
|
Cherry-picked onto dev as part of the bug resolution campaign (commit-and-merge loop). Changes verified with typecheck and focused tests. |
Summary
execin Cursor generic tool-use filtering, including theopencodex-responsesnamespace formexec_command/shell_commandalias, so Cursor is not instructed to call tools absent from the child catalogexecremains registered inmcp_toolsand is surfaced back to Codex through the Responses client-tool suspension path instead of native local execFixes #1661.
Verification
bun test ./tests/cursor-tool-definitions.test.ts ./tests/cursor-blob.test.ts ./tests/cursor-tool-continuation.test.ts— 91 passed, 0 failedbun test ./tests/cursor-*.test.ts— 518 passed, 0 failedbun x tsc --noEmit— passedbun run privacy:scan— passedgit diff --check— passedScope
Bug fix and architecture documentation only. No GUI or user-facing text direction change.
Summary by CodeRabbit
Enhancements
exectool alongside legacy shell aliases.exectool during generic tool-use prompts while filtering unrelated tools.execcalls now continue through the client-tool flow with proper progress events and deferred completion.Documentation
Tests
execcontinuation behavior.