Skip to content

cursor: Test Grok 4.6 Fast parameter mapping - #1550

Closed
jontonsoup wants to merge 2 commits into
lidge-jun:devfrom
jontonsoup:cursor-grok-4.6-fast
Closed

cursor: Test Grok 4.6 Fast parameter mapping#1550
jontonsoup wants to merge 2 commits into
lidge-jun:devfrom
jontonsoup:cursor-grok-4.6-fast

Conversation

@jontonsoup

@jontonsoup jontonsoup commented Aug 12, 2026

Copy link
Copy Markdown

Summary

  • Add regression coverage for the Grok 4.6 Fast Cursor wire contract already implemented on dev: base model grok-4.6 with separate effort and fast parameters.
  • Assert the static Cursor catalog exposes grok-4.6-fast.

Verification

  • ./node_modules/.bin/bun test tests/cursor-effort-suffix.test.ts tests/cursor-discovery.test.ts tests/cursor-static-catalog.test.ts (23 passed)
  • ./node_modules/.bin/bun run typecheck
  • Full bun run test attempted; unrelated loopback-server tests cannot bind ephemeral port 0 in this sandbox (EADDRINUSE).

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed. (No docs change: production support is already present on dev; this PR adds missing regression coverage.)
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. (Tests only; no security boundary changed.)

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

  • All CI tests are green on my local testing.

  • I pushed my PR to the latest dev commit.

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

Summary by CodeRabbit

  • Tests
    • Added coverage confirming discovery of the grok-4.6-fast model.
    • Added regression coverage ensuring effort and Fast settings are sent correctly with this model.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2bac526a-8fb8-4f80-a474-e88a099f2652

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 68dd7df2-981d-47f7-bd3d-4cb7eb4e9775

📥 Commits

Reviewing files that changed from the base of the PR and between c125b61 and 2a39ce3.

📒 Files selected for processing (2)
  • tests/cursor-discovery.test.ts
  • tests/cursor-effort-suffix.test.ts

📝 Walkthrough

Walkthrough

The PR adds Cursor test coverage for grok-4.6-fast discovery and request translation. It verifies the grok-4.6 model ID and separate effort and fast parameters.

Changes

Cursor Grok 4.6 Fast coverage

Layer / File(s) Summary
Discovery and request-parameter regression tests
tests/cursor-discovery.test.ts, tests/cursor-effort-suffix.test.ts
The discovery test requires grok-4.6-fast in the static model seed. The effort-suffix test verifies the grok-4.6 model ID and separate effort and fast parameters for high-effort requests.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: enhancement

Suggested reviewers: lidge-jun, jbaehova

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the regression tests for Grok 4.6 Fast parameter mapping, which is the primary change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • review readiness checklist open (0/4 boxes ticked).

What to do

  • Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

  • ⬜ All CI tests are green on my local testing.
  • ⬜ I pushed my PR to the latest dev commit.
  • ⬜ I resolved all correct Codex and CodeRabbit findings.
  • ⬜ My PR is ready for review.

0/4 boxes ticked.

This PR stays in draft until every box above is ticked.

@jontonsoup

Copy link
Copy Markdown
Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@jontonsoup jontonsoup closed this Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant