pixels: truncate SDL_SetPaletteColors input array silently - #16334
Merged
Merged
Conversation
Collaborator
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
SDL_SetPaletteColorsreturn true even if the input array is too large, documenting the truncation behavior.Description
This function currently has two failure conditions:
Curiously, in the second condition, the colors that fit are still written, although false is returned. This seems somewhat confusing, and I'd suggest improving it in one of two ways:
This PR currently implements the former option (tests are passing), but I'd be happy to change it to the latter, since it is a somewhat opinionated change. I understand that the current behavior can help detect a size mismatch, since there is no public API for retrieving the size of an
SDL_Palette. However, in either case, it's behavior that's worth documenting.Existing Issue(s)
None.