Suppress deprecation warnings - #16300
Open
jasonbobier wants to merge 2 commits into
Open
jasonbobier wants to merge 2 commits into
jasonbobier wants to merge 2 commits into
Conversation
Collaborator
|
@icculus, do we actually want to silence these deprecation warnings? |
Contributor
Author
|
I would argue that you do because they are noise that hide actual warnings. These aren't real warnings because you are supporting OS versions that require the code that cause the warnings. Hiding each individually means that it is easy to search for them later whenever you update your minimum OS requirements. And a warning free build should always be the end goal imo. |
Collaborator
|
Yeah, I'm pretty sure these are all fallbacks where we have a more modern approach in place for newer systems. Gonna go over all of these though, to make sure we can't just delete a few of them. What is the minimum macOS at this point? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the code is written (well copied and pasted all over :)) by me, but the comments are a mix of my comments and what Claude told me to make sure that I was giving accurate notes.
Description
Wrapped the deprecation warnings in:
clang diagnostic ignored "-Wdeprecated-declarations"Also added swiftpm related directories to the .gitignore in preparation for another PR.
NOTE: This only hides the warnings to clean up the build. It does not attempt to modernize the calling sites. I looked at that as well, but because of support back to 10.13, many of the sites couldn't be fully modernized.
Existing Issue(s)