Skip to content

Suppress deprecation warnings - #16300

Open
jasonbobier wants to merge 2 commits into
libsdl-org:mainfrom
jasonbobier:suppress-deprecation-warnings
Open

jasonbobier wants to merge 2 commits into
libsdl-org:mainfrom
jasonbobier:suppress-deprecation-warnings

Conversation

@jasonbobier

Copy link
Copy Markdown
Contributor
  • I confirm that I am the author of this code and release it to the SDL project under the zlib license. This contribution does not contain code from other sources, including code generated by a Large Language Model ("AI").

Note that the code is written (well copied and pasted all over :)) by me, but the comments are a mix of my comments and what Claude told me to make sure that I was giving accurate notes.

Description

Wrapped the deprecation warnings in:
clang diagnostic ignored "-Wdeprecated-declarations"

Also added swiftpm related directories to the .gitignore in preparation for another PR.

NOTE: This only hides the warnings to clean up the build. It does not attempt to modernize the calling sites. I looked at that as well, but because of support back to 10.13, many of the sites couldn't be fully modernized.

Existing Issue(s)

@slouken slouken added this to the 3.x milestone Sep 13, 2026
@slouken

slouken commented Sep 13, 2026

Copy link
Copy Markdown
Collaborator

@icculus, do we actually want to silence these deprecation warnings?

@jasonbobier

Copy link
Copy Markdown
Contributor Author

I would argue that you do because they are noise that hide actual warnings. These aren't real warnings because you are supporting OS versions that require the code that cause the warnings. Hiding each individually means that it is easy to search for them later whenever you update your minimum OS requirements. And a warning free build should always be the end goal imo.

@icculus

icculus commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

Yeah, I'm pretty sure these are all fallbacks where we have a more modern approach in place for newer systems.

Gonna go over all of these though, to make sure we can't just delete a few of them. What is the minimum macOS at this point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants