Skip to content

🐛 Fix tab reset issue when versions update via realtime #3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MH4GF merged 1 commit into from
Sep 25, 2025
Merged

🐛 Fix tab reset issue when versions update via realtime #3599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...ts/SessionDetailPage/hooks/useRealtimeVersionsWithSchema/useRealtimeVersionsWithSchema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import { buildingSchemaVersionsSchema } from '@liam-hq/db'
import { type Schema, schemaSchema } from '@liam-hq/schema'
import { useCallback, useEffect, useState, useTransition } from 'react'
import { useCallback, useEffect, useRef, useState, useTransition } from 'react'
import * as v from 'valibot'
import { createClient } from '../../../../libs/db/client'
import { useViewMode } from '../../hooks/viewMode'
Expand Down Expand Up @@ -31,6 +31,7 @@ export function useRealtimeVersionsWithSchema({
const [selectedVersion, setSelectedVersion] = useState<Version | null>(
initialVersions[0] ?? null,
)
const prevVersionsLengthRef = useRef(initialVersions.length)

const [displayedSchema, setDisplayedSchema] = useState<Schema>(
initialDisplayedSchema,
Expand Down Expand Up @@ -91,9 +92,13 @@ export function useRealtimeVersionsWithSchema({
useEffect(() => {
const targetVersion = versions[0] ?? null
setSelectedVersion(targetVersion)
if (targetVersion !== null) {

// Call onChangeSelectedVersion only when a new version is added
if (versions.length > prevVersionsLengthRef.current && targetVersion) {
onChangeSelectedVersion(targetVersion)
}

prevVersionsLengthRef.current = versions.length
}, [versions, onChangeSelectedVersion])

Comment thread
junkisai marked this conversation as resolved.
useEffect(() => {
Expand Down