chore: update workflows#547
Open
ldez wants to merge 1 commit into
Open
Conversation
ldez
force-pushed
the
feat/update-workflows
branch
from
95ca792 to
e324a87
Compare
aarongable
reviewed
May 26, 2026
| persist-credentials: false | ||
| - uses: actions/setup-go@v6 | ||
| with: | ||
| go-version: stable |
Contributor
There was a problem hiding this comment.
Why change this?
Suggested change
| go-version: stable | |
| go-version-file: go.mod |
Contributor
Author
There was a problem hiding this comment.
Because lego requires min go1.25 but pebble uses go1.24.
The Go version used to compile lego doesn't have to match the Go version used to compile pebble.
I can use oldstable if you want, as lego always uses Go latest-1 (== oldstable).
ldez
force-pushed
the
feat/update-workflows
branch
from
e324a87 to
f32156b
Compare
Contributor
Author
|
Because of PR #548 I was forced to rewrite the PR from scratch, this was not fun. |
ldez
force-pushed
the
feat/update-workflows
branch
4 times, most recently
from
8fc5076 to
ff789b1
Compare
ldez
force-pushed
the
feat/update-workflows
branch
from
ff789b1 to
d03f80f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the versions of the actions to the latest possible and applied some security good practices.
I also updated golangci-lint to the latest version and lego to v5.
Not in this PR, but I recommend several things to improve security and maintainability:
The fact to use goreleaser was rejected in 2019, but it's still think that it's the best way to automate the release process.
This is more maintainable than the current process with upload and download of artifacts.