[Evaluator] Add option to restart failed calculations - #257
Open
SimonBoothroyd wants to merge 4 commits into
Open
[Evaluator] Add option to restart failed calculations#257SimonBoothroyd wants to merge 4 commits into
SimonBoothroyd wants to merge 4 commits into
Conversation
Owner
|
@j-wags This is totally on me for failing to review it after several months. Is this code still correct? Do we still want this in a future release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability for the Evaluator target to restart any failed calculations up to a specified number of times before failing. This adds some resilience in cases of rare failures due to e.g. calculations landing on a badly configured compute node.