Repository navigation
Conversation
Cwooper
added a commit
to Cwooper/pdf
that referenced
this pull request
Oct 5, 2026
The binary data after an inline image's ID was read as tokens, so an
unbalanced "(" in it opened a string that swallowed the rest of the
page, and other bytes counted as malformed operands. Interpret now skips
the data up to the first EI between whitespace, and its callers still
see the ID and EI operators. This is only a skip: it leaves room for
parsing the image dictionary and data, as upstream PR ledongthuc#89 proposes.
Cwooper
added a commit
to Cwooper/pdf
that referenced
this pull request
Oct 5, 2026
The binary data after an inline image's ID was read as tokens, so an
unbalanced "(" in it opened a string that swallowed the rest of the
page, and other bytes counted as malformed operands. Interpret now skips
the data up to the first EI between whitespace, and its callers still
see the ID and EI operators. This is only a skip: it leaves room for
parsing the image dictionary and data, as upstream PR ledongthuc#89 proposes.
Cwooper
added a commit
to Cwooper/pdf
that referenced
this pull request
Oct 6, 2026
The binary data after an inline image's ID was read as tokens, so an
unbalanced "(" in it opened a string that swallowed the rest of the
page, and other bytes counted as malformed operands. Interpret now skips
the data up to the first EI between whitespace, and its callers still
see the ID and EI operators. This is only a skip: it leaves room for
parsing the image dictionary and data, as upstream PR ledongthuc#89 proposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #30
Saving image data as string because I don't want to break current API.
Add
Value.RawBytesfor getting image data conveniently.An example of extracting inline image from 99.pdf: