Repository navigation
feat: Add support for "UniGB-UCS2-H" encoding. - #56
Conversation
|
Thanks for the PR — this is a clean fix for #55. The approach is correct: 1. Reuse the existing
func utf16Decode(s string) string {
var u []uint16
for i := 0; i < len(s); i += 2 {
u = append(u, uint16(s[i])<<8|uint16(s[i+1]))
}
return string(utf16.Decode(u))
}Could you simplify 2. Make the test test only the encoder
3. Minor: copyright header The new Everything else looks good — thanks again! |
|
@ledongthuc You're right. I changed my code. |
|
@kvii Hi, it's good to merge now. Just got a conflict from page_test.go file |
|
@kvii seems the fix is failed. Could you check again? |
|
looks good! |
Fix #55