chore: bump Rocq version and fix stale aliases - #690
Merged
Merged
Conversation
lzy0505
self-requested a review
September 4, 2026 16:58
Collaborator
|
#1263 is accurate (seeing #1264 be fed back into Iris-Lean is pretty cool too, haha) |
MackieLoeffel
approved these changes
Sep 4, 2026
MackieLoeffel
left a comment
MackieLoeffel
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR. This looks good to me.
About the envs_to_prop PR in Iris Rocq, should we add some Rocq ignore for this?
| #rocq_ignore bi.pure_ne "No Proper type class in Lean" | ||
| #rocq_ignore bi_rewrite_relation "Rocq-specific setoid-rewriting infrastructure" | ||
| #rocq_ignore bi_later_mixin_id "BiLaterMixin with trivial later has trivial proofs regarding later" | ||
| #rocq_ignore bi_later_mixin_True "BiLaterMixin with trivial later has trivial proofs regarding later" |
Collaborator
There was a problem hiding this comment.
Maybe we still want to have this smart constructor as a sanity check, even if the proofs are trivial?
Contributor
Author
There was a problem hiding this comment.
Would a smart constructor expressed in terms of BI.ofPersistentlyDiscrete (commit c3b2e75) make sense?
lzy0505
reviewed
Sep 4, 2026
| ([∗set] y ∈ FiniteSet.filter φ X, Φ y) ∗ | ||
| (∀ Ψ : A → PROP, (□ (∀ y, ⌜y ∈ X⌝ → ⌜¬ φ y⌝ → Φ y -∗ Ψ y)) -∗ | ||
| ([∗set] y ∈ FiniteSet.filter φ X, Ψ y) -∗ [∗set] y ∈ X, Ψ y) := by | ||
| have hdisj : FiniteSet.filter φ X ## (X \ FiniteSet.filter φ X) := |
Contributor
Author
There was a problem hiding this comment.
Did some refactoring with a helper theorem.
Commit: 0ea7930
lzy0505
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump the Rocq version, port the recent changes and fix the stale aliases.
Resolves #593.
Refer to the diff between the two Iris-Rocq revisions.
The following changes are being ported:
big_sepS_filter_acc_impl.rocq_ignoreentry forbi_later_mixin_idis now forbi_later_mixin_True.persistently_exist_1from the BI interface.<only0>modality.BiPersistentlyExistandBiPersistentlyForallinstances inBI/SiProp.lean.<subj>-related theorems intoBI/MonPred.lean.later_laterNandlaterN_later.rocq_ignoreentry for themax_Zbogus unit instance.832a5cdauth_ucmra_mixinasmra_ucmra_mixin.The following change is already done and does not need to be addressed by this PR (@markusdemedeiros Can you confirm whether it is up-to-date?):
heap_closed_alloc.The following changes are specific to Iris-Rocq and thus not applicable:
envs_to_prop.env_subenv.Checklist
authorssection of any appropriate files