chore: Standardize the per-file copyright notices. - #686
Merged
Merged
Conversation
markusdemedeiros
requested review from
Kaptch,
MackieLoeffel and
lzy0505
and removed request for
MackieLoeffel and
lzy0505
August 29, 2026 14:37
markusdemedeiros
marked this pull request as ready for review
August 29, 2026 14:37
MackieLoeffel
approved these changes
Aug 31, 2026
MackieLoeffel
left a comment
MackieLoeffel
left a comment
Collaborator
There was a problem hiding this comment.
Good idea to clean this up. My understanding is also that this is fine copyright-wise. I am not fully sure if the notice file is even necessary, but I guess it does not hurt to have it.
Kaptch
approved these changes
Aug 31, 2026
lzy0505
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor thing that has bothered me for a while. This PR changes all of the headers to have a uniform copyright header. I preserved the
Authorsfield, but it has no impact on copyright.As far as I can tell this is within the parameters of the Apache 2.0 license, as long as we make a git tag with the old headers before merging this (see the new file
NOTICE). The license says they need to be preserved, but preserving a snapshot of them in the history should be fine.