feat: Port algebra/monoid.v and algebra/big_op.v - #132
Merged
lzy0505 merged 14 commits intoMar 16, 2026
Merged
Conversation
lzy0505
marked this pull request as ready for review
January 26, 2026 14:08
This was referenced Jan 29, 2026
lzy0505
force-pushed
the
zliu/algebra-bigop-monoid
branch
from
March 2, 2026 23:43
60a08c9 to
7b97935
Compare
lzy0505
marked this pull request as draft
March 2, 2026 23:44
lzy0505
marked this pull request as ready for review
March 4, 2026 20:04
Collaborator
Author
|
I've rebased this PR to use the new FiniteMap API. Can you have a look? @markusdemedeiros |
Collaborator
|
Ok, I'm done! Look over my changes and merge when you are ready. |
Collaborator
Author
|
Thanks for cleaning up! Looks good to me. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #113
algebra/monoid.vbig_opLandbig_opMparts ofalgebra/big_op.vProofs for some map lemmas are longer than those for their Rocq counterparts because we’re working with generic finite maps while Rocq only uses gmap.
Checklist
PORTING.mdas appropriateauthorssection of any appropriate files