refactor: Clean up tactic implementations - #119
Merged
Merged
Conversation
lzy0505
self-requested a review
January 20, 2026 13:52
Collaborator
|
Please let me know when the PR is ready. I will review it. |
MackieLoeffel
force-pushed
the
msammler/cleanup_tactics
branch
2 times, most recently
from
January 21, 2026 15:37
40051bb to
39e7ff2
Compare
Collaborator
Author
|
@lzy0505 This is ready to review. |
lzy0505
reviewed
Jan 21, 2026
lzy0505
reviewed
Jan 22, 2026
lzy0505
reviewed
Jan 22, 2026
lzy0505
reviewed
Jan 22, 2026
lzy0505
left a comment
lzy0505
left a comment
Collaborator
There was a problem hiding this comment.
This PR looks great! Ready for merging with minor comments.
- Collect everything related to Hyps in Expr.lean - Make all proof mode theorems private - Deduplicate code in icases - Add error messages for failing typeclass searches - Tweak icases such that the code path does not depend on the result of TC synthesis - Define iintuitionistic and ispatial as special cases of icases - Add test cases for failures - Introduce a type for intropatterns - Force forall introduction to use a pure intro pattern, similar to cases - Add more precise error location for intro patterns - Add proof mode term support for icases - Significantly simplify iassumption
MackieLoeffel
force-pushed
the
msammler/cleanup_tactics
branch
from
January 22, 2026 07:39
39e7ff2 to
6d486a0
Compare
markusdemedeiros
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #114
TC synthesis
cases