-
Notifications
You must be signed in to change notification settings - Fork 11
feat(components): add size prop to Input #1953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zakk-verrilli-ld
wants to merge
11
commits into
main
Choose a base branch
from
zverrilli/feat/input-size-variants
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5c61d40
feat(components): add size prop to Input
zakk-verrilli-ld fc211fa
docs(components): drop breaking-change note from Input size changeset
zakk-verrilli-ld e2deefb
fix(components): restore picker trigger height after Input size refactor
zakk-verrilli-ld 5e4c9be
fix(components): keep picker trigger height via Input base, not Button
zakk-verrilli-ld 4fa3732
resolve to size vars
zakk-verrilli-ld 6e5d1d8
fix(components): revert Input base padding-block to 5px literal
zakk-verrilli-ld a0662ff
fix(components): fixed Input heights
zakk-verrilli-ld cb5e785
fix(components): use min-height so TextArea grows, Input keeps floor
zakk-verrilli-ld b4228c0
fix(components): don't forward Input style props to TextArea/Group DOM
zakk-verrilli-ld 6f2ff99
fix(components): reset nested field min-height inside Group
zakk-verrilli-ld b5dbec3
refactor(components): extract shared field shell; decouple Button pic…
zakk-verrilli-ld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@launchpad-ui/components': minor | ||
| --- | ||
|
|
||
| Add a `size` prop to `Input` with `small` (24px tall) and `medium` (32px tall, the default) variants, matching the corresponding `Button` sizes so inputs and buttons align when placed side by side. `small` uses 11px text to match `Button`'s small height. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import type { Meta, StoryObj } from '@storybook/react-vite'; | ||
|
|
||
| import { Input } from '../src/Input'; | ||
|
|
||
| const meta: Meta<typeof Input> = { | ||
| title: 'Components/Forms/Input', | ||
| component: Input, | ||
| parameters: { | ||
| figma: { | ||
| design: | ||
| 'https://www.figma.com/design/98HKKXL2dTle29ikJ3tzk7/%F0%9F%9A%80-LaunchPad?node-id=1-34456&m=dev', | ||
| }, | ||
| docs: { | ||
| description: { | ||
| component: ` | ||
| An input allows a user to input text. | ||
|
|
||
| Usually composed within a [TextField](/docs/components-forms-textfield--docs) alongside a [Label](/docs/components-content-label--docs) for an accessible field. | ||
| `, | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| export default meta; | ||
|
|
||
| type Story = StoryObj<typeof Input>; | ||
|
|
||
| export const Default: Story = { | ||
| args: { | ||
| 'aria-label': 'Example', | ||
| defaultValue: 'Value', | ||
| }, | ||
| }; | ||
|
|
||
| /** | ||
| * Use the `size` prop to match the height of adjacent controls such as [Button](/docs/components-buttons-button--docs). | ||
| */ | ||
| export const Sizes: Story = { | ||
| render: () => ( | ||
| <div style={{ display: 'flex', flexDirection: 'column', gap: '1rem' }}> | ||
| <Input aria-label="Small" size="small" defaultValue="Small" /> | ||
| <Input aria-label="Medium" size="medium" defaultValue="Medium" /> | ||
| </div> | ||
| ), | ||
| }; | ||
|
|
||
| /** | ||
| * The `minimal` variant removes the resting border for use in denser or inline layouts. | ||
| */ | ||
| export const Variants: Story = { | ||
| render: () => ( | ||
| <div style={{ display: 'flex', flexDirection: 'column', gap: '1rem' }}> | ||
| <Input aria-label="Default" variant="default" defaultValue="Default" /> | ||
| <Input aria-label="Minimal" variant="minimal" defaultValue="Minimal" /> | ||
| </div> | ||
| ), | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.