Collapse the done entries, and re-run the budget on a body edit - #88
Conversation
The queue's completed entries carried the narrative of how each change was implemented, which the context-budget spec forbids in as many words. Every fact dropped was read at the place that owns it first: the 800 boundary in change-slicing's living spec, the two floors at their FLOOR constants, the refilling settings.local in the agent-permissions spec, the equivalent mutants in mutation-floor's design and spec. Two did not survive that test. The ask entries confirmed live after the merge appear in no archive, so they stay as the entry's outcome. The skills-lock patch is work nobody has done, so it moves to the open queue, where it belonged. The always-on set goes 495 lines to 479 against its ~500 budget. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe diff-budget workflow now runs for edited pull requests. A regression test verifies the complete event set. ChangesWorkflow and plan updates
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: 🟡 Moderate · up to The PR makes the budget check reevaluate pull-request body edits and condenses completed planning entries, but the added regression test appears syntactically invalid because the YAML parse expression is repeated without separators, so merge should wait until that test is corrected. The plan rewrite also needs bounded cleanup to verify the retained historical claim and use complete archive paths. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
The gate honours an `oversize:` marker in the pull request body, but the workflow named no activity types, so it listened for opened, synchronize and reopened alone. A marker added after the last push was therefore never read: the check kept reporting a verdict on a body that had since changed, and the only way to clear it was an empty commit. #87 was cleared by accident — a merge commit happened to supply the synchronize. change-slicing requires CI to fail unless the body carries the marker, which is a statement about the body as it stands. This makes that true. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Reduces each completed queue entry in
PLAN.mdto its outcome and its archive path. The always-on set goes 495 lines to 479 against the ~500 thecontext-budgetcapability sets.Closes no acceptance criterion. It applies one that already stands — PLAN.md holds the open queue and the standing constraints, which says a completed entry "SHALL NOT carry the narrative of how it was implemented" — rather than changing anything the spec says.
Also carries a fix the stack turned up: the diff-budget workflow named no activity types, so it listened for
opened,synchronizeandreopenedalone. Theoversize:override lives in the pull request body, so a marker added after the last push was never read — the check kept reporting a verdict on a body that had since changed, and only an empty commit could clear it. #87 was cleared by accident, a merge commit happening to supply thesynchronize.change-slicingrequires CI to fail unless the body carries the marker, which is a statement about the body as it stands, so this is the implementation catching up with the spec rather than a change to it. The trigger is pinned by a test that also asserts the three defaults survive — namingtypesat all is what stops them applying, so fixing one and silently losing the others is the easy mistake.Every fact dropped was read at the place that owns it before it was dropped, which is what the spec asks for instead of assuming the archive holds it: the boundary at exactly 800 in
change-slicing's living spec, the two floors at theirFLOORconstants and the reason each last moved beside them, the refillingsettings.local.jsonin theagent-permissionsspec, the equivalent mutants inmutation-floor's archived design and its living spec.Two did not survive that test and did not go:
askentries confirmed live in a session started after the merge appear in no archived change. An archive is not edited to receive a fact found later, so it stays as that entry's outcome.skills-lock.jsonpatchskill-provenancedrafted is work nobody has done. It moves to the open queue, where it belonged.To check by hand: nothing runs over
PLAN.md. The reviewer's check is that no dropped sentence names a fact the tree does not carry elsewhere.Summary by CodeRabbit
New Features
Documentation
Tests