Skip to content

Collapse the done entries, and re-run the budget on a body edit - #88

Merged
laidrivm merged 2 commits into
mainfrom
chore/collapse-plan-done
Aug 13, 2026
Merged

Collapse the done entries, and re-run the budget on a body edit#88
laidrivm merged 2 commits into
mainfrom
chore/collapse-plan-done

Conversation

@laidrivm

@laidrivm laidrivm commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Reduces each completed queue entry in PLAN.md to its outcome and its archive path. The always-on set goes 495 lines to 479 against the ~500 the context-budget capability sets.

Closes no acceptance criterion. It applies one that already stands — PLAN.md holds the open queue and the standing constraints, which says a completed entry "SHALL NOT carry the narrative of how it was implemented" — rather than changing anything the spec says.

Also carries a fix the stack turned up: the diff-budget workflow named no activity types, so it listened for opened, synchronize and reopened alone. The oversize: override lives in the pull request body, so a marker added after the last push was never read — the check kept reporting a verdict on a body that had since changed, and only an empty commit could clear it. #87 was cleared by accident, a merge commit happening to supply the synchronize.

change-slicing requires CI to fail unless the body carries the marker, which is a statement about the body as it stands, so this is the implementation catching up with the spec rather than a change to it. The trigger is pinned by a test that also asserts the three defaults survive — naming types at all is what stops them applying, so fixing one and silently losing the others is the easy mistake.

Every fact dropped was read at the place that owns it before it was dropped, which is what the spec asks for instead of assuming the archive holds it: the boundary at exactly 800 in change-slicing's living spec, the two floors at their FLOOR constants and the reason each last moved beside them, the refilling settings.local.json in the agent-permissions spec, the equivalent mutants in mutation-floor's archived design and its living spec.

Two did not survive that test and did not go:

  • The ask entries confirmed live in a session started after the merge appear in no archived change. An archive is not edited to receive a fact found later, so it stays as that entry's outcome.
  • The skills-lock.json patch skill-provenance drafted is work nobody has done. It moves to the open queue, where it belonged.

To check by hand: nothing runs over PLAN.md. The reviewer's check is that no dropped sentence names a fact the tree does not carry elsewhere.

Summary by CodeRabbit

  • New Features

    • Pull request checks now run when a pull request description is edited, in addition to existing activity triggers.
  • Documentation

    • Updated project tracking to consolidate completed work, add archive references, and clearly list an outstanding lockfile update.
  • Tests

    • Added coverage confirming checks run for pull request description edits and existing pull request events.

The queue's completed entries carried the narrative of how each change was
implemented, which the context-budget spec forbids in as many words. Every
fact dropped was read at the place that owns it first: the 800 boundary in
change-slicing's living spec, the two floors at their FLOOR constants, the
refilling settings.local in the agent-permissions spec, the equivalent
mutants in mutation-floor's design and spec.

Two did not survive that test. The ask entries confirmed live after the
merge appear in no archive, so they stay as the entry's outcome. The
skills-lock patch is work nobody has done, so it moves to the open queue,
where it belonged.

The always-on set goes 495 lines to 479 against its ~500 budget.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ae8db349-02aa-4705-9b05-4a19ac5e98b9

📥 Commits

Reviewing files that changed from the base of the PR and between b1342b0 and 60235ab.

📒 Files selected for processing (3)
  • .github/workflows/diff-budget.yml
  • PLAN.md
  • scripts/diff-budget.test.ts

📝 Walkthrough

Walkthrough

The diff-budget workflow now runs for edited pull requests. A regression test verifies the complete event set. PLAN.md updates completed-work records and adds a pending skills-lock.json item.

Changes

Workflow and plan updates

Layer / File(s) Summary
Diff-budget edited trigger
.github/workflows/diff-budget.yml, scripts/diff-budget.test.ts
The workflow now handles edited pull request events. The test verifies edited, opened, synchronize, and reopened.
Plan queue records
PLAN.md
The Done queue entries were condensed and reorganized. The Open queue now lists the unapplied skills-lock.json patch.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: 🟡 Moderate · up to 60235

The PR makes the budget check reevaluate pull-request body edits and condenses completed planning entries, but the added regression test appears syntactically invalid because the YAML parse expression is repeated without separators, so merge should wait until that test is corrected. The plan rewrite also needs bounded cleanup to verify the retained historical claim and use complete archive paths.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes both main changes: condensing completed plan entries and rerunning the budget check after body edits.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/collapse-plan-done

Comment @coderabbitai help to get the list of available commands.

@laidrivm
laidrivm changed the base branch from feat/file-size-cap-1 to main August 13, 2026 17:33
The gate honours an `oversize:` marker in the pull request body, but the
workflow named no activity types, so it listened for opened, synchronize
and reopened alone. A marker added after the last push was therefore never
read: the check kept reporting a verdict on a body that had since changed,
and the only way to clear it was an empty commit. #87 was cleared by
accident — a merge commit happened to supply the synchronize.

change-slicing requires CI to fail unless the body carries the marker,
which is a statement about the body as it stands. This makes that true.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@laidrivm laidrivm changed the title Reduce each done entry to its outcome and its archive path Collapse the done entries, and re-run the budget on a body edit Aug 13, 2026
@laidrivm
laidrivm merged commit ffd4b73 into main Aug 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant