driver: add initial type hints for common driver code

[rpoisel]

Description

This PR starts adding type annotations incrementally, as discussed in #1945.

It adds ty as a development dependency and configures it to check a small initial module of the codebase: labgrid/driver/common.py.

Verified locally with:

uv run --extra dev pytest tests/test_driver_common.py
uv run ruff check labgrid/driver/common.py tests/test_driver_common.py
uv run ruff format --check --diff labgrid/driver/common.py tests/test_driver_common.py
uv run ty check

Checklist

• Documentation for the feature
• Tests for the feature
• The arguments and description in doc/configuration.rst have been updated
• Add a section on how to use the feature to doc/usage.rst
• Add a section on how to use the feature to doc/development.rst
• PR has been tested
• Man pages have been regenerated

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.0%. Comparing base (879f4d1) to head (0cd4874).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #1946   +/-   ##
======================================
  Coverage    61.0%   61.0%           
======================================
  Files         182     182           
  Lines       14899   14901    +2     
======================================
+ Hits         9095    9103    +8     
+ Misses       5804    5798    -6     

Flag	Coverage Δ
3.10	61.0% <100.0%> (+<0.1%)	⬆️
3.11	61.0% <100.0%> (+<0.1%)	⬆️
3.12	61.0% <100.0%> (+<0.1%)	⬆️
3.13	61.0% <100.0%> (+<0.1%)	⬆️
3.14	61.0% <100.0%> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[Emantor]

Changes look good to me, do you also want to add a ty check run to this PR for the CI or is it too early for that?

[rpoisel]

Do you also want to add a ty check run to this PR for the CI or is it too early for that?

Thanks for your approval!

I'd be happy to add such check to CI. If you don't mind, I'd do that in a separate commit.

EDIT: just re-pushed to get the commit of this PR verified.

[Bastian-Krause]

I'd be happy to add such check to CI. If you don't mind, I'd do that in a separate commit.

You didn't to that, did you?

Maybe we should drop the mypy.ini with this PR? (edit: depending on the mypy question below)

[Bastian-Krause]

So we need to mark each instantiation of an attr.s class like that? I don't think that scales..

Doesn't mypy work better with that?

[Emantor]

AFAIR mypy had the same issues, thats why we never got anywhere with the initial type hints.

[rpoisel]

In the separate PR that will add ty as a dependency incl. CI check, I'll disable the too-many-positional-arguments check for the whole repo until there is clean support for attrs classes.

At the moment, ty does not really support attrs. See astral-sh/ty#2404 if you want to learn more.

[rpoisel]

I'd be happy to add such check to CI. If you don't mind, I'd do that in a separate commit.
You didn't to that, did you?

No, I didn't because I want to do that in a separate commit.

Maybe we should drop the mypy.ini with this PR?

I would leave it for now.

Now that you mention that: I think I will even remove the ty dependency entirely in this PR and add it in the (separate) PR that also adds the CI typing checks.