util/managedfile: ensure directory containing symlink exists for sync_to_resource() - #1662
Open
rvdgracht wants to merge 1 commit into
Open
util/managedfile: ensure directory containing symlink exists for sync_to_resource()#1662rvdgracht wants to merge 1 commit into
rvdgracht wants to merge 1 commit into
Conversation
Member
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1662 +/- ##
========================================
- Coverage 61.0% 61.0% -0.1%
========================================
Files 182 182
Lines 14874 14901 +27
========================================
+ Hits 9083 9098 +15
- Misses 5791 5803 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
1 task
Bastian-Krause
added
the
needs rebase
Bastian-Krause
force-pushed
the
master
branch
2 times, most recently
from
July 8, 2026 10:27
da22369 to
a46186f
Compare
Bastian-Krause
changed the title
Bastian-Krause
added
enhancement
and removed
fix
needs rebase
Member
|
After looking at this again, I think this makes sense. I've rebased this and added the local use case. |
Bastian-Krause
requested review from
Emantor
and removed request for
Bastian-Krause
July 8, 2026 10:33
…_to_resource() When the internal dir contains a subdir that does not yet exist (i.e. '/srv/tftp/board-23/') the symlink creation fails. Try to create the necessary directories. Signed-off-by: Robin van der Gracht <robin@protonic.nl> [bst: added local mkdir path, adjusted commit message] Signed-off-by: Bastian Krause <bst@pengutronix.de>
Member
|
@Emantor Could you take a look at this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the internal dir contains a subdir that does not yet exist (i.e. '/srv/tftp/board-23/') the symlink creation will fail.