Skip to content

fix: still a prob with permission pop-up - #382

Merged
kunkka19xx merged 1 commit into
mainfrom
fix/grant-permission-1
Aug 17, 2026
Merged

fix: still a prob with permission pop-up#382
kunkka19xx merged 1 commit into
mainfrom
fix/grant-permission-1

Conversation

@kunkka19xx

@kunkka19xx kunkka19xx commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • Still a problem with grant all button. the pop-up doesn't show with calendar and contacts

Testing

  • macOS app (if apps/macos/** touched): cd apps/macos/LauncherApp && swift test
  • macOS app (if apps/macos/** touched): xcodebuild -project "apps/macos/LauncherApp/look-app.xcodeproj" -scheme "Look" -configuration Debug -sdk macosx build
  • Manual verification completed (if UI/behavior changed)

Screenshots / Recordings (if UI changed)

Checklist

  • I have read and agree to the CLA (CLA.md)
  • PR title is clear and scoped
  • Docs updated for user-visible changes
  • No secrets or private files included
  • Backward compatibility considered

Summary by CodeRabbit

  • Bug Fixes
    • Improved permission dialog presentation by temporarily adjusting launcher windows so dialogs remain visible and accessible.
    • Restored window behavior correctly after multiple overlapping permission requests finish.
    • Excluded small status and popover windows from these adjustments.

@kunkka19xx kunkka19xx changed the title fix: still a prob with per pop-up fix: still a prob with permission pop-up Aug 17, 2026
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 64a28344-af7b-4013-9206-bfdc131ad986

📥 Commits

Reviewing files that changed from the base of the PR and between 280bbe8 and 7cd25aa.

📒 Files selected for processing (1)
  • apps/macos/LauncherApp/look-app/Support/Launcher/PermissionPrompt.swift

Included review availability: Your plan includes up to 4 reviews per rolling hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

PermissionPrompt now manages launcher window levels while permission dialogs run. It tracks concurrent requests, lowers qualifying visible windows, activates the application, and restores captured levels after the final request completes.

Changes

Permission prompt presentation

Layer / File(s) Summary
Presentation state and window filtering
apps/macos/LauncherApp/look-app/Support/Launcher/PermissionPrompt.swift
The prompt tracks active requests, captures original window levels, applies a minimum launcher window size, and documents dialog visibility constraints.
Scoped window-level adjustment
apps/macos/LauncherApp/look-app/Support/Launcher/PermissionPrompt.swift
run activates the application, lowers qualifying visible windows during presentation, and restores their original levels after the final concurrent request ends.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 7cd25

This localized permission-prompt change has no identified merge-blocking risk and is merge-ready after normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the issue and testing, but it omits the required Why, Changes, and Risks / Notes sections and provides no screenshots for the UI change. Add the Why, Changes, and Risks / Notes sections, and provide before-and-after screenshots or explain why screenshots are unavailable.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title identifies the permission pop-up issue and matches the main change, although its wording is informal.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/grant-permission-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kunkka19xx
kunkka19xx merged commit 59033da into main Aug 17, 2026
11 checks passed
@kunkka19xx kunkka19xx mentioned this pull request Aug 17, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant