Skip to content

chore: merge re-usable parts, add beta mark - #377

Merged
kunkka19xx merged 1 commit into
mainfrom
chore/help-unify
Aug 17, 2026
Merged

chore: merge re-usable parts, add beta mark#377
kunkka19xx merged 1 commit into
mainfrom
chore/help-unify

Conversation

@kunkka19xx

@kunkka19xx kunkka19xx commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • Merge catalog in help and setting/shortcuts -> one
  • add a beta mark for ai mode

Testing

  • apps/linows
    • macOS app (if apps/macos/** touched): cd apps/macos/LauncherApp && swift test
    • macOS app (if apps/macos/** touched): xcodebuild -project "apps/macos/LauncherApp/look-app.xcodeproj" -scheme "Look" -configuration Debug -sdk macosx build
    • Manual verification completed (if UI/behavior changed)

Checklist

  • I have read and agree to the CLA (CLA.md)
  • PR title is clear and scoped
  • Docs updated for user-visible changes
  • No secrets or private files included
  • Backward compatibility considered

Summary by CodeRabbit

  • New Features

    • Added a centralized shortcut catalog covering navigation, command mode, AI mode, clipboard history, views, Pomodoro, Todo, and other panels.
    • Updated Help and Settings to display organized, consistent shortcut groups.
    • Added topic-based shortcut browsing, including dedicated AI shortcuts.
    • Shortcut keys now appear in aligned, easy-to-scan badges and rows.
  • Bug Fixes

    • Improved shortcut documentation consistency and ensured shortcut entries remain uniquely identifiable and addressable.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5ec06961-c1b9-49f2-a619-45522dae209e

📥 Commits

Reviewing files that changed from the base of the PR and between 0bb6270 and 3bc6ac8.

📒 Files selected for processing (6)
  • apps/macos/LauncherApp/LauncherLogicTests/ShortcutCatalogTests.swift
  • apps/macos/LauncherApp/Package.swift
  • apps/macos/LauncherApp/look-app/Support/ShortcutCatalog.swift
  • apps/macos/LauncherApp/look-app/Support/UI/ShortcutGroupView.swift
  • apps/macos/LauncherApp/look-app/Views/Launcher/LauncherSubviews.swift
  • apps/macos/LauncherApp/look-app/Views/Settings/ThemeSettingsView+Shortcuts.swift

Included review availability: Your plan includes up to 4 reviews per rolling hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The PR introduces a canonical shortcut catalog with derived entries and validation tests. Launcher help and settings now use shared catalog-backed rendering. AI mode displays a conditional BETA badge.

Changes

Shortcut catalog integration

Layer / File(s) Summary
Catalog model and shortcut definitions
apps/macos/LauncherApp/look-app/Support/ShortcutCatalog.swift, apps/macos/LauncherApp/LauncherLogicTests/ShortcutCatalogTests.swift, apps/macos/LauncherApp/Package.swift
Defines shortcut entries, topics, groups, catalog contents, derived prefix and command entries, and catalog consistency tests.
Shared shortcut group rendering
apps/macos/LauncherApp/look-app/Support/UI/ShortcutGroupView.swift
Adds a themed SwiftUI view for shortcut keys, actions, and remappability badges.
Help and settings catalog consumers
apps/macos/LauncherApp/look-app/Views/Launcher/LauncherSubviews.swift, apps/macos/LauncherApp/look-app/Views/Settings/ThemeSettingsView+Shortcuts.swift
Replaces hard-coded help and settings shortcut data with catalog-backed topics, groups, and shared views. Adds the conditional AI-mode BETA badge.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: ⚪ Minimal · up to 3bc6a

The PR consolidates shortcut catalog UI components and adds a beta label for AI mode; no actionable merge-blocking risk remains beyond normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant LauncherHelpTopic
  participant ShortcutCatalog
  participant ShortcutGroupView
  participant shortcutsTab
  LauncherHelpTopic->>ShortcutCatalog: select topic groups
  ShortcutCatalog-->>LauncherHelpTopic: return shortcut groups
  LauncherHelpTopic->>ShortcutGroupView: render topic groups
  shortcutsTab->>ShortcutCatalog: read all groups
  ShortcutCatalog-->>shortcutsTab: return shortcut groups
  shortcutsTab->>ShortcutGroupView: render shortcut groups
Loading

Possibly related PRs

  • kunkka19xx/look#316: Modified shortcut documentation that this PR centralizes in the canonical catalog.
  • kunkka19xx/look#374: Changed the launcher help topic implementation that this PR replaces with catalog-backed topics.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes a summary, relevant testing, and checklist, but it omits the required Why, Changes, Risks / Notes, and UI screenshots sections. Add the missing Why, Changes, Risks / Notes, and Before/After screenshot sections, and keep the testing and checklist details aligned with the template.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately identifies the catalog reuse and AI beta-mark changes, although “re-usable parts” is somewhat broad.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/help-unify

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kunkka19xx
kunkka19xx merged commit a4e91a2 into main Aug 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant