fix(fleet): handle oversized snapshot inputs - #3522
Open
jleemcf wants to merge 11 commits into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Reviews (2): Last reviewed commit: "no-mistakes(document): correct stale sec..." | Re-trigger Greptile |
Rebasing onto main picks up "remove legacy remote snapshot reads" (kunchenguid#3501), which deleted the legacy producer fallback: the parent now samples a registered home only by reading that home's state/home-summary.json. Both secondmate fixtures still drove the deleted producer path, so they stopped sampling at all. Publish the ledger with fm-home-summary-refresh.sh in the oversized-summary fixture, and drive the unusable-summary cases by writing rc-file noise, an empty file, a repeated document, and a wrong-shape document into the ledger file the parent actually reads. Track the local oversized reason string renamed by kunchenguid#3501.
jleemcf
force-pushed
the
fm/fm-fleet-snapshot-argv-limit
branch
from
September 2, 2026 15:56
3a049cc to
bb045f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
bin/fm-test-run.sh tests/fm-fleet-snapshot-view.test.shbin/fm-test-run.sh tests/fm-home-summary-refresh.test.sh tests/fm-secondmate-reconcile.test.shbin/fm-test-run.sh tests/fm-bearings-snapshot.test.shbin/fm-lint.sh