feat: add TerminationGracePeriodSeconds support to liveness probe#16657
feat: add TerminationGracePeriodSeconds support to liveness probe#16657AruneshDwivedi wants to merge 1 commit into
Conversation
Addresses issue knative#15823. Adds validation and defaulting for the terminationGracePeriodSeconds field in liveness probes for Knative revisions. Changes: - pkg/apis/serving/k8s_validation.go: Added validation for terminationGracePeriodSeconds (must be non-negative) - pkg/apis/serving/v1/revision_defaults.go: Added defaulting function applyLivenessProbeDefaults that sets terminationGracePeriodSeconds=1 when liveness probe is configured but terminationGracePeriodSeconds is not set - Called applyLivenessProbeDefaults in RevisionSpec.applyDefault() The field was already allowed via ProbeMask in fieldmask.go (line 392), but lacked validation and defaulting.
|
Welcome @AruneshDwivedi! It looks like this is your first PR to knative/serving 🎉 |
knative-prow
Bot
added
the
size/S
|
Hi @AruneshDwivedi. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
Bot
added
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AruneshDwivedi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 participant
Addresses issue #15823.
Adds validation and defaulting for the field in liveness probes for Knative revisions.
Changes:
The field was already allowed via ProbeMask in fieldmask.go (line 392), but lacked validation and defaulting.
Closes #15823.